linux-kernel - Re: [PATCH v6] mm/hmm/test: use char dev with struct device to get device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220330143458.GM64706@ziepe.ca>
Date:   Wed, 30 Mar 2022 11:34:58 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     mpenttil@...hat.com
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        apopple@...dia.com, jhubbard@...dia.com, rcampbell@...dia.com,
        vbabka@...e.cz
Subject: Re: [PATCH v6] mm/hmm/test: use char dev with struct device to get
 device node

On Wed, Mar 30, 2022 at 03:47:25AM +0300, mpenttil@...hat.com wrote:
> From: Mika Penttilä <mpenttil@...hat.com>
> 
> HMM selftests use an in-kernel pseudo device to emulate device private
> memory. The pseudo device registers a major device range for two pseudo
> device instances. User space has a script that reads /proc/devices in
> order to find the assigned major number, and sends that to mknod(1),
> once for each node.
> 
> Change this to properly use cdev and struct device APIs.
> 
> Delete the /proc/devices parsing from the user-space test script, now
> that it is unnecessary.
> 
> Also, deleted an unused field in struct dmirror_device: devmem.
> 
> Signed-off-by: Mika Penttilä <mpenttil@...hat.com>
> Reviewed-by: John Hubbard <jhubbard@...dia.com>
> Cc: Alistair Popple <apopple@...dia.com>
> Cc: Ralph Campbell <rcampbell@...dia.com>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: Vlastimil Babka <vbabka@...e.cz>
> ---
> v6:
>         - remove device names array
>         - check return value of dev_set_name()
> v5:
>         - fix whitespace
>         . delete unused structure field
> v4:
>         - fix commit log
> v3:
>         - use cdev_device_add() instead of miscdevice
> v2:
>         - Cleanups per review comments from John Hubbard
>         - Added Tested-by and Ccs
> 
> 
>  lib/test_hmm.c                         | 13 ++++++++++---
>  tools/testing/selftests/vm/test_hmm.sh |  6 ------
>  2 files changed, 10 insertions(+), 9 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason