linux-kernel - Re: [PATCH v3.1 0/4] KVM: x86: Use static calls to reduce kvm_pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee0892bb-ba1e-251d-8e19-ac26b4c0799d@gmail.com>
Date:   Wed, 30 Mar 2022 23:02:54 +0800
From:   Like Xu <like.xu.linux@...il.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Like Xu <likexu@...cent.com>
Subject: Re: [PATCH v3.1 0/4] KVM: x86: Use static calls to reduce kvm_pmu_ops
 overhead

On 30/3/2022 7:50 am, Sean Christopherson wrote:
> This is a minor iteration on Like's v3 to allow kvm_pmu_ops (the global
> variable, not the struct) be static.  I ran the PMU unit tests and compiled,
> but otherwise it's untested.  Strongly recommend waiting for Like to give
> a thumbs up before applying :-)

Uh, thank you for picking up this optimization and it passes my test cases.

> 
> [*] https://lore.kernel.org/all/20220307115920.51099-1-likexu@tencent.com
> 
> Like Xu (4):
>    KVM: x86: Move kvm_ops_static_call_update() to x86.c
>    KVM: x86: Copy kvm_pmu_ops by value to eliminate layer of indirection
>    KVM: x86: Move .pmu_ops to kvm_x86_init_ops and tag as __initdata
>    KVM: x86: Use static calls to reduce kvm_pmu_ops overhead
> 
>   arch/x86/include/asm/kvm-x86-pmu-ops.h | 31 ++++++++++++
>   arch/x86/include/asm/kvm_host.h        | 17 +------
>   arch/x86/kvm/pmu.c                     | 66 ++++++++++++++++++--------
>   arch/x86/kvm/pmu.h                     |  7 +--
>   arch/x86/kvm/svm/pmu.c                 |  2 +-
>   arch/x86/kvm/svm/svm.c                 |  2 +-
>   arch/x86/kvm/vmx/pmu_intel.c           |  2 +-
>   arch/x86/kvm/vmx/vmx.c                 |  2 +-
>   arch/x86/kvm/x86.c                     | 21 +++++++-
>   9 files changed, 102 insertions(+), 48 deletions(-)
>   create mode 100644 arch/x86/include/asm/kvm-x86-pmu-ops.h
> 
> 
> base-commit: 19164ad08bf668bca4f4bfbaacaa0a47c1b737a6