linux-kernel - Re: [PATCH V4 1/1] Intel Sky Lake-E host root ports check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8e5e5ce-aac3-fe37-d710-88639a1a62f3@deltatee.com>
Date:   Wed, 30 Mar 2022 09:20:26 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Shlomo Pongratz <shlomopongratz@...il.com>,
        linux-pci@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, andrew.maier@...eticom.com,
        bhelgaas@...gle.com, jgg@...dia.com, helgaas@...nel.org,
        Shlomo Pongratz <shlomop@...ops.com>
Subject: Re: [PATCH V4 1/1] Intel Sky Lake-E host root ports check.




On 2022-03-30 08:08, Shlomo Pongratz wrote:
> In commit 7b94b53db34f ("PCI/P2PDMA: Add Intel Sky Lake-E Root Ports B, C, D to
> the whitelist")
> Andrew Maier added the Sky Lake-E additional devices
> 2031, 2032 and 2033 root ports to the already existing 2030 device.
> 
> The Intel devices 2030, 2031, 2032 and 2033 which are root ports A, B, C and D,
> respectively and if all exist they will occupy slots 0 till 3 in that order.
> 
> The original code handled only the case where the devices in the whiltlist are

s/whiltlist/whitelist/

> host bridges and assumed that they will be found on slot 0.
> 
> This assumption doesn't hold for root ports so an explicit test was added to
> cover this case.
> 
> Signed-off-by: Shlomo Pongratz <shlomop@...ops.com>

This patch looks good to me. Much cleaner and easier to understand than
the previous ones.

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>

Thanks,

Logan