linux-kernel - Re: [Cluster-devel] [PATCH] gfs2: Add check for mempool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YkR9uT3/eRHqGtbe@infradead.org>
Date:   Wed, 30 Mar 2022 08:56:41 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     rpeterso@...hat.com, agruenba@...hat.com, cluster-devel@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [Cluster-devel] [PATCH] gfs2: Add check for mempool_alloc

On Fri, Mar 11, 2022 at 04:36:16PM +0800, Jiasheng Jiang wrote:
> As the potential failure of mempool_alloc(),
> it could return NULL pointer.
> Therefore, it should be better to check it
> in order to avoid the dereference of the NULL
> pointer.
> 
> Fixes: e8c92ed76900 ("GFS2: Clean up log write code path")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>

Please explain how it could fail to start with.