linux-kernel - Re: [PATCH 1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Mar 2022 17:51:25 +0000
From:   Caleb Connolly <caleb@...nolly.tech>
To:     Joel Selvaraj <jo@...amily.in>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Amit Pundir <amit.pundir@...aro.org>
Subject: Re: [PATCH 1/4] arm64: dts: qcom: sdm845-xiaomi-beryllium: change firmware path and use mbn format



On 30/03/2022 07:45, Joel Selvaraj wrote:
> The "qcom/sdm845/" path conflicts with db845c's firmware that are
> present in the linux-firmware package. Xiaomi uses their own signed
> firmware for Poco F1 and can't use the db845c's firmware. So let's
> use "qcom/sdm845/beryllium/" to distinguish Poco F1's firmware files.
>
> For easier handling and packaging, the mdt+bXX files are squashed
> using Bjorn Andersson's pil-squasher tool from this link:
> https://github.com/andersson/pil-squasher
Reviewed-by: Caleb Connolly <caleb@...nolly.tech>
>
> Signed-off-by: Joel Selvaraj <jo@...amily.in>
> ---
>   arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> index 367389526b41..27ba9ad1ad02 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> @@ -121,7 +121,7 @@ vreg_s4a_1p8: vreg-s4a-1p8 {
>
>   &adsp_pas {
>   	status = "okay";
> -	firmware-name = "qcom/sdm845/adsp.mdt";
> +	firmware-name = "qcom/sdm845/beryllium/adsp.mbn";
>   };
>
>   &apps_rsc {
> @@ -208,7 +208,7 @@ vreg_l26a_1p2: ldo26 {
>
>   &cdsp_pas {
>   	status = "okay";
> -	firmware-name = "qcom/sdm845/cdsp.mdt";
> +	firmware-name = "qcom/sdm845/beryllium/cdsp.mbn";
>   };
>
>   &dsi0 {
> @@ -262,7 +262,7 @@ &gpu {
>
>   	zap-shader {
>   		memory-region = <&gpu_mem>;
> -		firmware-name = "qcom/sdm845/a630_zap.mbn";
> +		firmware-name = "qcom/sdm845/beryllium/a630_zap.mbn";
>   	};
>   };
>
> @@ -289,7 +289,7 @@ &mdss {
>
>   &mss_pil {
>   	status = "okay";
> -	firmware-name = "qcom/sdm845/mba.mbn", "qcom/sdm845/modem.mdt";
> +	firmware-name = "qcom/sdm845/beryllium/mba.mbn", "qcom/sdm845/beryllium/modem.mbn";
>   };
>
>   &pm8998_gpio {
> --
> 2.35.1
>

--
Kind Regards,
Caleb