linux-kernel - Re: [PATCH] perf tools/perf/python/tracepoint.py: Converted to Python3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YkTB0ft2kVDk5yny@kernel.org>
Date:   Wed, 30 Mar 2022 17:47:13 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Tanu M <tanu235m@...il.com>
Cc:     linux-perf-users@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        mingo@...hat.com, peterz@...radead.org
Subject: Re: [PATCH] perf tools/perf/python/tracepoint.py: Converted to
 Python3

Em Wed, Mar 30, 2022 at 05:39:07PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sun, Mar 27, 2022 at 11:08:46PM -0700, Tanu M escreveu:
> > Hi,
> > I have converted the tracepoint.py file to python3 as many of the
> > files in tools/perf are already written in python3.
> > 
> > Signed-off-by: Tanusree Debnath <tanu235m@...il.com>
> 
> Got this:
> 
> ⬢[acme@...lbox perf]$ patch -p1 < ~/wb/1.patch
> patching file tools/perf/python/tracepoint.py
> patch: **** malformed patch at line 119: prev_state=0x%x ==> next_comm=%s next_pid=%d next_prio=%d" % (
> 
> ⬢[acme@...lbox perf]$
> 
> I'll apply it by hand, please check your e-mail client.

you forgot to add the author of that example to the Cc list, done, here
is how it ended up:

commit e2774e6d25c12478d43e47e5d268aee6441a8479
Author: Tanu M <tanu235m@...il.com>
Date:   Sun Mar 27 23:08:46 2022 -0700

    perf python: Convert tracepoint.py example to python3
    
    Convert the tracepoint.py file to python3 as many of the files in
    tools/perf are already written in python3.
    
    Committer testing:
    
      # export PYTHONPATH=/tmp/build/perf/python/
      # python3 ~acme/git/perf/tools/perf/python/tracepoint.py | head
      time 67394457376909 prev_comm=swapper/12 prev_pid=0 prev_prio=120 prev_state=0x0 ==> next_comm=gnome-terminal- next_pid=3313 next_prio=120
      time 67394457807669 prev_comm=python3 prev_pid=1485930 prev_prio=120 prev_state=0x1 ==> next_comm=swapper/13 next_pid=0 next_prio=120
      time 67394457811859 prev_comm=swapper/13 prev_pid=0 prev_prio=120 prev_state=0x0 ==> next_comm=python3 next_pid=1485930 next_prio=120
      time 67394457824929 prev_comm=python3 prev_pid=1485930 prev_prio=120 prev_state=0x1 ==> next_comm=swapper/13 next_pid=0 next_prio=120
      time 67394457831899 prev_comm=swapper/13 prev_pid=0 prev_prio=120 prev_state=0x0 ==> next_comm=python3 next_pid=1485930 next_prio=120
      time 67394457842299 prev_comm=python3 prev_pid=1485930 prev_prio=120 prev_state=0x1 ==> next_comm=swapper/13 next_pid=0 next_prio=120
      time 67394457844179 prev_comm=swapper/13 prev_pid=0 prev_prio=120 prev_state=0x0 ==> next_comm=python3 next_pid=1485930 next_prio=120
      time 67394457853879 prev_comm=python3 prev_pid=1485930 prev_prio=120 prev_state=0x1 ==> next_comm=swapper/13 next_pid=0 next_prio=120
      time 67394457856339 prev_comm=swapper/13 prev_pid=0 prev_prio=120 prev_state=0x0 ==> next_comm=python3 next_pid=1485930 next_prio=120
      time 67394457865659 prev_comm=python3 prev_pid=1485930 prev_prio=120 prev_state=0x1 ==> next_comm=swapper/13 next_pid=0 next_prio=120
      Traceback (most recent call last):
        File "/var/home/acme/git/perf/tools/perf/python/tracepoint.py", line 48, in <module>
          main()
        File "/var/home/acme/git/perf/tools/perf/python/tracepoint.py", line 37, in main
          print("time %u prev_comm=%s prev_pid=%d prev_prio=%d prev_state=0x%x ==> next_comm=%s next_pid=%d next_prio=%d" % (
      BrokenPipeError: [Errno 32] Broken pipe
      #
    
    Signed-off-by: Tanu M <tanu235m@...il.com>
    Tested-by: Arnaldo Carvalho de Melo <acme@...hat.com>
    Cc: Jiri Olsa <jolsa@...nel.org>
    Cc: Peter Zijlstra <peterz@...radead.org>
    Link: https://lore.kernel.org/linux-perf-users/CAPS78prawYzRZnyhWjgOnGw4EwoswNwztvfZFdCOPOydFzVwzQ@mail.gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

diff --git a/tools/perf/python/tracepoint.py b/tools/perf/python/tracepoint.py
index 461848c7f57dca3d..bba68a6d45156183 100755
--- a/tools/perf/python/tracepoint.py
+++ b/tools/perf/python/tracepoint.py
@@ -34,7 +34,7 @@ def main():
             if not isinstance(event, perf.sample_event):
                 continue
 
-            print "time %u prev_comm=%s prev_pid=%d prev_prio=%d prev_state=0x%x ==> next_comm=%s next_pid=%d next_prio=%d" % (
+            print("time %u prev_comm=%s prev_pid=%d prev_prio=%d prev_state=0x%x ==> next_comm=%s next_pid=%d next_prio=%d" % (
                    event.sample_time,
                    event.prev_comm,
                    event.prev_pid,
@@ -42,7 +42,7 @@ def main():
                    event.prev_state,
                    event.next_comm,
                    event.next_pid,
-                   event.next_prio)
+                   event.next_prio))
 
 if __name__ == '__main__':
     main()


- Arnaldo