linux-kernel - Re: [PATCH] kbuild: fix empty ${PYTHON} in scripts/link-vmlinux.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUUWCAfyznemv6cUYKQSTtPO+9ww7v8oLxK=Hd2o6gMNbg@mail.gmail.com>
Date:   Wed, 30 Mar 2022 09:06:31 +0200
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH] kbuild: fix empty ${PYTHON} in scripts/link-vmlinux.sh

On Wed, Mar 30, 2022 at 5:17 AM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> On Mon, Mar 28, 2022 at 7:15 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
> >
> > The two commits
> >
> >   d8d2d38275c1 ("kbuild: remove PYTHON variable")
> >   a8cccdd95473 ("init: lto: ensure initcall ordering")
> >
> > were applied in the same development cycle, in two different trees.
> >
> > After they were merged together, this ${PYTHON} expands to an empty
> > string.
> >
> > Therefore, ${srctree}/scripts/jobserver-exec is executed directly.
> > (it has the executable bit set)
> >
> > This is working but let's fix the code into the intended form.
>
> Thanks for the patch!
> Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
>

Good catch.
I was not aware that scripts/jobserver-exec was executable.
Debian/unstable now switched to python v3.10.x as default "python3"
and I will have this patch in my next series for testing.
Thanks.

Reviewed-by: Sedat Dilek <sedat.dilek@...il.com>

- Sedat -


> >
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> > ---
> >
> >  scripts/link-vmlinux.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> > index f704034ebbe6..20f44504a644 100755
> > --- a/scripts/link-vmlinux.sh
> > +++ b/scripts/link-vmlinux.sh
> > @@ -50,7 +50,7 @@ gen_initcalls()
> >  {
> >         info GEN .tmp_initcalls.lds
> >
> > -       ${PYTHON} ${srctree}/scripts/jobserver-exec             \
> > +       ${PYTHON3} ${srctree}/scripts/jobserver-exec            \
> >         ${PERL} ${srctree}/scripts/generate_initcall_order.pl   \
> >                 ${KBUILD_VMLINUX_OBJS} ${KBUILD_VMLINUX_LIBS}   \
> >                 > .tmp_initcalls.lds
> > --
> > 2.32.0
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers