linux-kernel - Re: [PATCH] staging: r8188eu: Fix sparse endianness warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220330071100.GG3293@kadam>
Date:   Wed, 30 Mar 2022 10:11:00 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Charlie Sands <sandsch@...thvilleschools.net>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix sparse endianness warnings.

On Tue, Mar 29, 2022 at 11:14:05PM -0400, Charlie Sands wrote:
> This patch fixes sparse warnings about the endianness of different
> integers in the driver.
> 
> Signed-off-by: Charlie Sands <sandsch@...thvilleschools.net>

Thanks!  This is a bugfix though so it needs a fixes tag.

Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")

Otherwise:

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

It's surprising that this code works at all.  I maybe have said before
that I suspect the pppoe stuff has not been well tested.

regards,
dan carpenter