linux-kernel - Re: [PATCH] mtd: parsers: add support for Sercomm partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220330100958.57dc4d61@xps13>
Date:   Wed, 30 Mar 2022 10:09:58 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Mikhail Zhilkin <csharper2005@...il.com>
Cc:     Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Rob Herring <robh+dt@...nel.org>,
        NOGUCHI Hiroshi <drvlabo@...il.com>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Karim <Karimdplay@...il.com>, M <x1@...root.org>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] mtd: parsers: add support for Sercomm partitions

Hi Mikhail,

csharper2005@...il.com wrote on Tue, 29 Mar 2022 12:20:16 +0000:

> This adds an MTD partition parser for the Sercomm partition table that
> is used in some Beeline, Netgear and Sercomm routers.
> 
> The Sercomm partition map table contains real partition offsets, which
> may differ from device to device depending on the number and location of
> bad blocks on NAND.
> 
> Device tree example:
> partitions {
> 	compatible = "sercomm,sc-partitions", "fixed-partitions";
> 	#address-cells = <1>;
> 	#size-cells = <1>;
> 
> 	partition@0 {
> 		label = "u-boot";
> 		reg = <0x0 0x100000>;
> 		scpart-id = <0>;
> 		read-only;
> 	};
> };

You'll need a DT binding patch and Rob's ack!

> 
> This is essentially the same code as proposed by NOGUCHI Hiroshi
> <drvlabo@...il.com> here:

I would credit Hiroshi with a Suggested-by at least

> https://github.com/openwrt/openwrt/pull/1318#issuecomment-420607394

And use a Link: tag for this.

> 
> Signed-off-by: Mikhail Zhilkin <csharper2005@...il.com>
> ---


Thanks,
Miquèl