linux-kernel - Re: [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Mar 2022 10:17:59 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     tiwai@...e.com, kernel test robot <lkp@...el.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Jeremy Szu <jeremy.szu@...onical.com>,
        Werner Sembach <wse@...edocomputers.com>,
        Hui Wang <hui.wang@...onical.com>,
        Lucas Tanure <tanureal@...nsource.cirrus.com>,
        Cameron Berkenpas <cam@...-zeon.de>,
        Kailang Yang <kailang@...ltek.com>, Sami Loone <sami@...ne.fi>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020

On Wed, 30 Mar 2022 08:13:33 +0200,
Kai-Heng Feng wrote:
> 
> Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording
> issue") is to solve recording issue met on AL236, by matching codec
> variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256.
> 
> This match can be too broad and Mi Notebook Pro 2020 is broken by the
> patch.
> 
> Instead, use codec ID to be narrow down the scope, in order to make
> ALC256 unaffected.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484
> Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue")
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---
> v2:
>  Fix wrong comparison, || -> &&

Thanks, applied now.


Takashi