linux-kernel - Re: [PATCH] entry: fix compile error in dynamic_irqentry_exit_cond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkQog3+80izN1e1q@FVFF77S0Q05N>
Date:   Wed, 30 Mar 2022 10:53:07 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Sven Schnelle <svens@...ux.ibm.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] entry: fix compile error in
 dynamic_irqentry_exit_cond_resched()

On Wed, Mar 30, 2022 at 11:17:15AM +0200, Sven Schnelle wrote:
> Mark Rutland <mark.rutland@....com> writes:
> 
> > On Wed, Mar 30, 2022 at 10:43:28AM +0200, Sven Schnelle wrote:
> >> kernel/entry/common.c: In function ‘dynamic_irqentry_exit_cond_resched’:
> >> kernel/entry/common.c:409:14: error: implicit declaration of
> >> function ‘static_key_unlikely’; did you mean ‘static_key_enable’?
> >> [-Werror=implicit-function-declaration]
> >>   409 |         if (!static_key_unlikely(&sk_dynamic_irqentry_exit_cond_resched))
> >>       |              ^~~~~~~~~~~~~~~~~~~
> >>       |              static_key_enable
> >> 
> >> static_key_unlikely() should be static_branch_unlikely().
> >> 
> >> Fixes: 99cf983cc8bca ("sched/preempt: Add PREEMPT_DYNAMIC using static keys")
> >> Signed-off-by: Sven Schnelle <svens@...ux.ibm.com>
> >
> > Sorry about this. FWIW:
> >
> > Reviewed-by: Mark Rutland <mark.rutland@....com>
> >
> > For context for others, this'll only show up on architectures which both use
> > the generic entry code and select CONFIG_HAVE_PREEMPT_DYNAMIC_KEY. Today, only
> > arm64 selects CONFIG_HAVE_PREEMPT_DYNAMIC_KEY, and it doesn't use the generic
> > entry code.
> >
> > Sven, I assume you're looking at wiring this up on s390 or parisc?
> 
> Yes, i'm looking whether we can use the same implementation on s390. :)
> 
> I reported it already on 03/18, but looks like that Mail was lost
> somehow:
> 
> https://www.spinics.net/lists/kernel/msg4283802.html

Ah; sorry, I didn't spot that somehow.

> I was wondering whether we can make dynamic_irqentry_exit_cond_resched()
> static, so it gets inlined. On s390 the compiler generates a branch to
> that function just to return immediately if the static key isn't enabled.
> With static it would get inlined, and therefore save one function call.
> What do you think?

I appreciate that it saves one call, but does that actually matter in practice,
given this is called only once per interrupt?

I'm not fundamentally opposed to changing it, but doing so would make it
different from all the other dynamic_*() cases which need the check to be
out-of-line to avoid bloating the callers, and it's not clear to me that we'd
gain much by doing so.

FWIW, on arm64 we had some additional conditions we have to check, so we roll
our own (out-of-line) implementation anyway. So doing something arch-specific
is also an option.

Thanks,
Mark.