linux-kernel - Re: [PATCH 2/2] kbuild: do not remove empty *.symtypes explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Mar 2022 11:27:48 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH 2/2] kbuild: do not remove empty *.symtypes explicitly

On Wed, Mar 30, 2022 at 3:28 AM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> On Mon, Mar 28, 2022 at 7:15 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
> >
> > Presumably, 'test -s $@ || rm -f $@' intends to remove the output when
> > the genksyms command fails.
> >
> > It is unneeded because .DELETE_ON_ERROR automatically removes the output
> > on failure.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> > ---
> >
> >  scripts/Makefile.build | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> > index 3f2985df4d60..974bb6435826 100644
> > --- a/scripts/Makefile.build
> > +++ b/scripts/Makefile.build
> > @@ -135,9 +135,7 @@ genksyms = scripts/genksyms/genksyms                \
> >  cmd_gensymtypes_c = $(CPP) -D__GENKSYMS__ $(c_flags) $< | $(genksyms)
> >
> >  quiet_cmd_cc_symtypes_c = SYM $(quiet_modtag) $@
> > -cmd_cc_symtypes_c =                                                         \
> > -    $(call cmd_gensymtypes_c,true,$@) >/dev/null;                           \
> > -    test -s $@ || rm -f $@
> > +      cmd_cc_symtypes_c = $(call cmd_gensymtypes_c,true,$@)
>
> Was it an accident that you removed the redirection of stdout to
> /dev/null here, but not also below?

It was an accident. I will fix it. Thanks.



> If quiet_modtag silences the output, perhaps the redirection should be
> dropped below as well?
>
> >
> >  $(obj)/%.symtypes : $(src)/%.c FORCE
> >         $(call cmd,cc_symtypes_c)
> > @@ -348,9 +346,7 @@ cmd_gensymtypes_S =                                                         \
> >      $(CPP) -D__GENKSYMS__ $(c_flags) -xc - | $(genksyms)
> >
> >  quiet_cmd_cc_symtypes_S = SYM $(quiet_modtag) $@
> > -cmd_cc_symtypes_S =                                                         \
> > -    $(call cmd_gensymtypes_S,true,$@) >/dev/null;                           \
> > -    test -s $@ || rm -f $@
> > +      cmd_cc_symtypes_S = $(call cmd_gensymtypes_S,true,$@) >/dev/null
> >
> >  $(obj)/%.symtypes : $(src)/%.S FORCE
> >         $(call cmd,cc_symtypes_S)
> > --
> > 2.32.0
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers



-- 
Best Regards
Masahiro Yamada