linux-kernel - Re: drivers/scsi/hisi_sas/hisi_sas_main.c:445 hisi_sas_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Mar 2022 12:49:00 +0100
From:   John Garry <john.garry@...wei.com>
To:     kernel test robot <lkp@...el.com>
CC:     <kbuild-all@...ts.01.org>, <linux-kernel@...r.kernel.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: drivers/scsi/hisi_sas/hisi_sas_main.c:445 hisi_sas_task_deliver()
 warn: inconsistent indenting

On 30/03/2022 08:23, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   1c24a186398f59c80adb9a967486b65c1423a59d
> commit: 095478a6e5bf590f2bbf341569eb25173c9c5f32 scsi: hisi_sas: Use libsas internal abort support
> date:   2 weeks ago
> config: powerpc64-randconfig-m031-20220330 (https://download.01.org/0day-ci/archive/20220330/202203301533.b4Hty4C7-lkp@intel.com/config)
> compiler: powerpc64-linux-gcc (GCC) 11.2.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> smatch warnings:
> drivers/scsi/hisi_sas/hisi_sas_main.c:445 hisi_sas_task_deliver() warn: inconsistent indenting
> 
> vim +445 drivers/scsi/hisi_sas/hisi_sas_main.c
> 

...

> 42e7a69368a585 John Garry  2015-11-18  437  	case SAS_PROTOCOL_SATA:
> 42e7a69368a585 John Garry  2015-11-18  438  	case SAS_PROTOCOL_STP:
> 095478a6e5bf59 John Garry  2022-03-11  439  	case SAS_PROTOCOL_STP_ALL:
> a2b3820bddfbff Xiang Chen  2018-05-09  440  		hisi_sas_task_prep_ata(hisi_hba, slot);
> 6f2ff1a1311e61 John Garry  2016-01-26  441  		break;
> 095478a6e5bf59 John Garry  2022-03-11  442  	case SAS_PROTOCOL_INTERNAL_ABORT:
> 095478a6e5bf59 John Garry  2022-03-11  443  		hisi_sas_task_prep_abort(hisi_hba, slot);
> dc313f6b125b09 John Garry  2021-12-15  444  		break;
> dc313f6b125b09 John Garry  2021-12-15 @445  	fallthrough;

This is already queued for removal.

> 42e7a69368a585 John Garry  2015-11-18  446  	default:
> 095478a6e5bf59 John Garry  2022-03-11  447  		return;
> 42e7a69368a585 John Garry  2015-11-18  448  	}
> 42e7a69368a585 John Garry  2015-11-18  449
> 1c09b663168bb5 Xiaofei Tan 2018-07-18  450  	WRITE_ONCE(slot->ready, 1);
> 42e7a69368a585 John Garry  2015-11-18  451
> 0e4620856b8933 John Garry  2021-12-15  452  	spin_lock(&dq->lock);
> 0e4620856b8933 John Garry  2021-12-15  453  	hisi_hba->hw->start_delivery(dq);
> 0e4620856b8933 John Garry  2021-12-15  454  	spin_unlock(&dq->lock);
> 42e7a69368a585 John Garry  2015-11-18  455  }
> 42e7a69368a585 John Garry  2015-11-18  456
> 
> :::::: The code at line 445 was first introduced by commit
> :::::: dc313f6b125b095d3d2683d94d5f69c8dc9bdc36 scsi: hisi_sas: Factor out task prep and delivery code
> 
> :::::: TO: John Garry <john.garry@...wei.com>
> :::::: CC: Martin K. Petersen <martin.petersen@...cle.com>
>