linux-kernel - Re: [PATCH AUTOSEL 5.17 31/66] printk: Add panic_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkRELPuydJ5Fn3It@kroah.com>
Date:   Wed, 30 Mar 2022 13:51:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Stephen Brennan <stephen.s.brennan@...cle.com>,
        Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        linux@...ck-us.net
Subject: Re: [PATCH AUTOSEL 5.17 31/66] printk: Add panic_in_progress helper

On Wed, Mar 30, 2022 at 07:46:10AM -0400, Sasha Levin wrote:
> From: Stephen Brennan <stephen.s.brennan@...cle.com>
> 
> [ Upstream commit 77498617857f68496b360081dde1a492d40c28b2 ]
> 
> This will be used help avoid deadlocks during panics. Although it would
> be better to include this in linux/panic.h, it would require that header
> to include linux/atomic.h as well. On some architectures, this results
> in a circular dependency as well. So instead add the helper directly to
> printk.c.
> 
> Suggested-by: Petr Mladek <pmladek@...e.com>
> Signed-off-by: Stephen Brennan <stephen.s.brennan@...cle.com>
> Reviewed-by: Petr Mladek <pmladek@...e.com>
> Reviewed-by: Sergey Senozhatsky <senozhatsky@...omium.org>
> Signed-off-by: Petr Mladek <pmladek@...e.com>
> Link: https://lore.kernel.org/r/20220202171821.179394-2-stephen.s.brennan@oracle.com
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  kernel/printk/printk.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 82abfaf3c2aa..0f8918f5f22a 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -257,6 +257,11 @@ static void __up_console_sem(unsigned long ip)
>  }
>  #define up_console_sem() __up_console_sem(_RET_IP_)
>  
> +static bool panic_in_progress(void)
> +{
> +	return unlikely(atomic_read(&panic_cpu) != PANIC_CPU_INVALID);
> +}
> +
>  /*
>   * This is used for debugging the mess that is the VT code by
>   * keeping track if we have the console semaphore held. It's
> -- 
> 2.34.1
> 

All 4 of the printk patches should not need to be backported to stable
kernels, thanks.  Please drop them all.

greg k-h