linux-kernel - Re: [PATCH linux-next] RDMA: simplify if-if to if-else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93D39EC2-6C71-45D8-883A-F8DAA6ECFEDF@oracle.com>
Date:   Wed, 30 Mar 2022 12:26:51 +0000
From:   Haakon Bugge <haakon.bugge@...cle.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     Guo Zhengkui <guozhengkui@...o.com>,
        Mustafa Ismail <mustafa.ismail@...el.com>,
        Shiraz Saleem <shiraz.saleem@...el.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Yishai Hadas <yishaih@...dia.com>,
        OFED mailing list <linux-rdma@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        "zhengkui_guo@...look.com" <zhengkui_guo@...look.com>
Subject: Re: [PATCH linux-next] RDMA: simplify if-if to if-else



> On 30 Mar 2022, at 13:32, Leon Romanovsky <leon@...nel.org> wrote:
> 
> On Wed, Mar 30, 2022 at 11:06:03AM +0000, Haakon Bugge wrote:
>> 
>> 
>>> On 30 Mar 2022, at 13:02, Leon Romanovsky <leon@...nel.org> wrote:
>>> 
>>> On Mon, Mar 28, 2022 at 09:08:59PM +0800, Guo Zhengkui wrote:
>>>> `if (!ret)` can be replaced with `else` for simplification.
>>>> 
>>>> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>
>>>> ---
>>>> drivers/infiniband/hw/irdma/puda.c | 4 ++--
>>>> drivers/infiniband/hw/mlx4/mcg.c   | 3 +--
>>>> 2 files changed, 3 insertions(+), 4 deletions(-)
>>>> 
>>> 
>>> Thanks,
>>> Reviewed-by: Leon Romanovsky <leonro@...dia.com>
>> 
>> Fix the unbalanced curly brackets at the same time?
> 
> I think that it is ok to have if () ... else { ... } code.


Hmm, doesn't the kernel coding style say:

"Do not unnecessarily use braces where a single statement will do."

[snip]

"This does not apply if only one branch of a conditional statement is a single statement; in the latter case use braces in both branches"


Thxs, Håkon


> 
> There is one place that needs an indentation fix, in mlx4, but it is
> faster to fix when applying the patch instead of asking to resubmit.
> 
> thanks
> 
>> 
>> 
>> Thxs, Håkon