linux-kernel - Re: [Patch v2 2/2] mm/vmscan: make sure wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220330142052.3g5n4cl6lqyekhan@master>
Date:   Wed, 30 Mar 2022 14:20:52 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     Wei Yang <richard.weiyang@...il.com>, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        ying.huang@...el.com, mgorman@...hsingularity.net,
        Miaohe Lin <linmiaohe@...wei.com>,
        Oscar Salvador <osalvador@...e.de>
Subject: Re: [Patch v2 2/2] mm/vmscan: make sure wakeup_kswapd with managed
 zone

On Wed, Mar 30, 2022 at 09:39:42AM +0200, David Hildenbrand wrote:
>On 29.03.22 03:09, Wei Yang wrote:
>> wakeup_kswapd() only wake up kswapd when the zone is managed.
>> 
>> For two callers of wakeup_kswapd(), they are node perspective.
>> 
>>   * wake_all_kswapds
>>   * numamigrate_isolate_page
>> 
>> If we picked up a !managed zone, this is not we expected.
>> 
>> This patch makes sure we pick up a managed zone for wakeup_kswapd(). And
>> it also use managed_zone in migrate_balanced_pgdat() to get the proper
>> zone.
>> 
>> Signed-off-by: Wei Yang <richard.weiyang@...il.com>
>> Cc: Miaohe Lin <linmiaohe@...wei.com>
>> Cc: David Hildenbrand <david@...hat.com>
>> Cc: "Huang, Ying" <ying.huang@...el.com>
>> Cc: Mel Gorman <mgorman@...hsingularity.net>
>> Cc: Oscar Salvador <osalvador@...e.de>
>> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>
>^ I'm not so sure about that SOB, actually Andrew should add that. But
>maybe there is good reason for it that I'm not aware of.
>

I see Andrew has added this for v1.

Maybe I should remove this since v2 has some minor adjustment to v1. :-)

>
>Reviewed-by: David Hildenbrand <david@...hat.com>
>
>-- 
>Thanks,
>
>David / dhildenb

-- 
Wei Yang
Help you, Help me