linux-kernel - Re: [RFC PATCH linux-next] mm/secretmem: secretmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJHvVchTGDbr0dUhDOs8iJHcNCmp8V_LYfLoVcBWYQmvJBPQMQ@mail.gmail.com>
Date:   Thu, 31 Mar 2022 10:40:18 -0700
From:   Axel Rasmussen <axelrasmussen@...gle.com>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH linux-next] mm/secretmem: secretmem_iops can be static

Thanks kernel test robot, it should indeed be static. I'll send a v2
with this fix.

On Thu, Mar 31, 2022 at 9:55 AM kernel test robot <lkp@...el.com> wrote:
>
> mm/secretmem.c:173:31: warning: symbol 'secretmem_iops' was not declared. Should it be static?
>
> Fixes: 24209f2f4d62 ("mm/secretmem: fix panic when growing a memfd_secret")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> ---
>  mm/secretmem.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index a83e98aa3a7b3..ddf45c0435be7 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -170,7 +170,7 @@ static int secretmem_setattr(struct user_namespace *mnt_userns,
>         return simple_setattr(mnt_userns, dentry, iattr);
>  }
>
> -const struct inode_operations secretmem_iops = {
> +static const struct inode_operations secretmem_iops = {
>         .setattr = secretmem_setattr,
>  };
>