linux-kernel - [PATCH] Bluetooth: btintel: fix btintel_download

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Mar 2022 10:49:59 -0700
From:   trix@...hat.com
To:     marcel@...tmann.org, johan.hedberg@...il.com, luiz.dentz@...il.com
Cc:     linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tom Rix <trix@...hat.com>
Subject: [PATCH] Bluetooth: btintel: fix btintel_download_firmware stub signature

From: Tom Rix <trix@...hat.com>

cppcheck returns this warning
btintel.c:1059]: (warning) Function 'btintel_download_firmware'
  argument order different: declaration
  'dev, fw, boot_param, ' definition 'hdev, ver, fw, boot_param'

By inspection, the stub version is missing
'struct intel_version *ver', so add it.

Fixes: ac0565462e33 ("Bluetooth: btintel: Check firmware version before download")
Signed-off-by: Tom Rix <trix@...hat.com>
---
 drivers/bluetooth/btintel.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
index e0060e58573c..66902866a5c1 100644
--- a/drivers/bluetooth/btintel.h
+++ b/drivers/bluetooth/btintel.h
@@ -281,6 +281,7 @@ static inline int btintel_read_boot_params(struct hci_dev *hdev,
 }
 
 static inline int btintel_download_firmware(struct hci_dev *dev,
+					    struct intel_version *ver,
 					    const struct firmware *fw,
 					    u32 *boot_param)
 {
-- 
2.26.3