| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Mar 2022 12:41:22 -0700
From: Arve Hjønnevåg <arve@...gle.com>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: kernel test robot <lkp@...el.com>,
Sudarshan Rajagopalan <sudaraja@...eaurora.org>,
kbuild-all@...ts.01.org,
"GNU/Weeb Mailing List" <gwml@...r.gnuweeb.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [ammarfaizi2-block:google/android/kernel/common/android12-trusty-5.10
1060/5872] arch/arm64/mm/mmu.c:1499:5: warning: no previous prototype for 'check_range_driver_managed'
On Thu, Mar 31, 2022 at 12:12 PM Suren Baghdasaryan <surenb@...gle.com> wrote:
>
> On Thu, Mar 31, 2022 at 3:17 AM kernel test robot <lkp@...el.com> wrote:
> >
> > Hi Sudarshan,
> >
> > FYI, the error/warning still remains.
>
> The warnings has been fixed in later patch:
> https://android-review.googlesource.com/c/kernel/common/+/1668705
> android12-trusty-5.10 needs to rebase to the latest android12-5.10 to fix this.
>
This branch is meant to be merged into vendor kernels that need the
trusty driver. We should not rebase it as that could create merge
conflicts. We could merge android12-5.10 but we don't have a good
reason to do so at this time as downstream branches already merge
android12-5.10 directly. The android12-trusty-5.10 branch itself is
only used to build the linux kernel for our emulator tests.
Arve Hjønnevåg
> >
> > tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-trusty-5.10
> > head: 07055bfd3d810d41a38354693dfaa55a6f8c0025
> > commit: 1b4aca7d82ae9b40145484fa09ceab38a6a06062 [1060/5872] ANDROID: arm64/mm: implement {populate/depopulate}_range_driver_managed
> > config: arm64-buildonly-randconfig-r005-20220331 (https://download.01.org/0day-ci/archive/20220331/202203311842.wFWvHrHn-lkp@intel.com/config)
> > compiler: aarch64-linux-gcc (GCC) 11.2.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://github.com/ammarfaizi2/linux-block/commit/1b4aca7d82ae9b40145484fa09ceab38a6a06062
> > git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
> > git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android12-trusty-5.10
> > git checkout 1b4aca7d82ae9b40145484fa09ceab38a6a06062
> > # save the config file to linux build tree
> > mkdir build_dir
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/mm/ drivers/gpu/drm/hisilicon/kirin/
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@...el.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> arch/arm64/mm/mmu.c:1499:5: warning: no previous prototype for 'check_range_driver_managed' [-Wmissing-prototypes]
> > 1499 | int check_range_driver_managed(u64 start, u64 size, const char *resource_name)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > In file included from include/linux/printk.h:7,
> > from include/linux/kernel.h:16,
> > from arch/arm64/mm/mmu.c:11:
> > arch/arm64/mm/mmu.c: In function 'check_range_driver_managed':
> > include/linux/kern_levels.h:5:25: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Wformat=]
> > 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
> > | ^~~~~~
> > include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH'
> > 11 | #define KERN_ERR KERN_SOH "3" /* error conditions */
> > | ^~~~~~~~
> > include/linux/printk.h:343:16: note: in expansion of macro 'KERN_ERR'
> > 343 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> > | ^~~~~~~~
> > arch/arm64/mm/mmu.c:1509:17: note: in expansion of macro 'pr_err'
> > 1509 | pr_err("%s: couldn't find memory resource for start 0x%lx\n",
> > | ^~~~~~
> >
> >
> > vim +/check_range_driver_managed +1499 arch/arm64/mm/mmu.c
> >
> > 1498
> > > 1499 int check_range_driver_managed(u64 start, u64 size, const char *resource_name)
> > 1500 {
> > 1501 struct mem_section *ms;
> > 1502 unsigned long pfn = __phys_to_pfn(start);
> > 1503 unsigned long end_pfn = __phys_to_pfn(start + size);
> > 1504 struct resource *res;
> > 1505 unsigned long flags;
> > 1506
> > 1507 res = lookup_resource(&iomem_resource, start);
> > 1508 if (!res) {
> > 1509 pr_err("%s: couldn't find memory resource for start 0x%lx\n",
> > 1510 __func__, start);
> > 1511 return -EINVAL;
> > 1512 }
> > 1513
> > 1514 flags = res->flags;
> > 1515
> > 1516 if (!(flags & IORESOURCE_SYSRAM_DRIVER_MANAGED) ||
> > 1517 strstr(resource_name, "System RAM (") != resource_name)
> > 1518 return -EINVAL;
> > 1519
> > 1520 for (; pfn < end_pfn; pfn += PAGES_PER_SECTION) {
> > 1521 ms = __pfn_to_section(pfn);
> > 1522 if (early_section(ms))
> > 1523 return -EINVAL;
> > 1524 }
> > 1525
> > 1526 return 0;
> > 1527 }
> > 1528
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://01.org/lkp
Powered by blists - more mailing lists