linux-kernel - Re: [PATCH v12 07/54] ceph: support legacy v1 encryption policy keysetup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkYMDRTcGC6sJO8l@gmail.com>
Date:   Thu, 31 Mar 2022 20:16:13 +0000
From:   Eric Biggers <ebiggers@...nel.org>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     ceph-devel@...r.kernel.org, xiubli@...hat.com, idryomov@...il.com,
        lhenriques@...e.de, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 07/54] ceph: support legacy v1 encryption policy
 keysetup

On Thu, Mar 31, 2022 at 11:30:43AM -0400, Jeff Layton wrote:
> From: Luís Henriques <lhenriques@...e.de>
> 
> fstests make use of legacy keysetup where the key description uses a
> filesystem-specific prefix.  Add this ceph-specific prefix to the
> fscrypt_operations data structure.
> 
> Signed-off-by: Luís Henriques <lhenriques@...e.de>
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---
>  fs/ceph/crypto.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ceph/crypto.c b/fs/ceph/crypto.c
> index a513ff373b13..d1a6595a810f 100644
> --- a/fs/ceph/crypto.c
> +++ b/fs/ceph/crypto.c
> @@ -65,6 +65,7 @@ static bool ceph_crypt_empty_dir(struct inode *inode)
>  }
>  
>  static struct fscrypt_operations ceph_fscrypt_ops = {
> +	.key_prefix		= "ceph:",
>  	.get_context		= ceph_crypt_get_context,
>  	.set_context		= ceph_crypt_set_context,
>  	.empty_dir		= ceph_crypt_empty_dir,
> -- 
> 2.35.1
> 

As I mentioned before
(https://lore.kernel.org/r/20200908042925.GI68127@sol.localdomain), I don't
think you should do this, given that the filesystem-specific key description
prefixes are deprecated.  In fact, they're sort of doubly deprecated, since
first they were superseded by "fscrypt:", and then "login" keys were
superseded by FS_IOC_ADD_ENCRYPTION_KEY.

How about updating fstests to use "fscrypt:" instead of "$FSTYP:" if $FSTYP is
not ext4 or f2fs?

Or maybe fstests should just use "fscrypt:" unconditionally, given that this has
been supported by ext4 and f2fs since 4.8, and 4.9 is now the oldest supported
LTS kernel.

- Eric