linux-kernel - Re: [PATCH] RISC-V: Declare per cpu boot data as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-00dae2b9-e45c-43c7-a67d-75c937215a19@palmer-mbp2014>
Date:   Thu, 31 Mar 2022 13:28:06 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     Atish Patra <atishp@...osinc.com>
CC:     linux-kernel@...r.kernel.org, Atish Patra <atishp@...osinc.com>,
        lkp@...el.com, aou@...s.berkeley.edu, atishp@...shpatra.org,
        anup@...infault.org, damien.lemoal@....com,
        devicetree@...r.kernel.org, jszhang@...nel.org,
        krzysztof.kozlowski@...onical.com, linux-riscv@...ts.infradead.org,
        Paul Walmsley <paul.walmsley@...ive.com>, robh+dt@...nel.org
Subject:     Re: [PATCH] RISC-V: Declare per cpu boot data as static

On Wed, 23 Mar 2022 10:17:26 PDT (-0700), Atish Patra wrote:
> The per cpu boot data is only used within the cpu_ops_sbi.c. It can
> be delcared as static.
>
> Fixes: 9a2451f18663 ("RISC-V: Avoid using per cpu array for ordered booting")
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Atish Patra <atishp@...osinc.com>
> ---
>  arch/riscv/kernel/cpu_ops_sbi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/cpu_ops_sbi.c b/arch/riscv/kernel/cpu_ops_sbi.c
> index dae29cbfe550..7f2ad008274f 100644
> --- a/arch/riscv/kernel/cpu_ops_sbi.c
> +++ b/arch/riscv/kernel/cpu_ops_sbi.c
> @@ -21,7 +21,7 @@ const struct cpu_operations cpu_ops_sbi;
>   * be invoked from multiple threads in parallel. Define a per cpu data
>   * to handle that.
>   */
> -DEFINE_PER_CPU(struct sbi_hart_boot_data, boot_data);
> +static DEFINE_PER_CPU(struct sbi_hart_boot_data, boot_data);
>
>  static int sbi_hsm_hart_start(unsigned long hartid, unsigned long saddr,
>  			      unsigned long priv)

Thanks, this is on for-next.