linux-kernel - Re: [PATCH] regulator: dt-bindings: maxim,max8997: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f8415ab-9eba-ac31-c645-7e543e0da39e@linaro.org>
Date:   Thu, 31 Mar 2022 23:18:36 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH] regulator: dt-bindings: maxim,max8997: convert to
 dtschema

On 31/03/2022 22:11, Krzysztof Kozlowski wrote:
> On 30/03/2022 12:44, Geert Uytterhoeven wrote:
>> Hi Krzysztof,
>>
>> On Fri, Oct 1, 2021 at 3:18 PM Krzysztof Kozlowski
>> <krzysztof.kozlowski@...onical.com> wrote:
>>> Convert the Maxim MAX8997 PMIC bindings to DT schema format.  Extend the
>>> examples with additional one copied from kernel's exynos4210-origen.dts.
>>> Also the binding descriptions are copied from old file, so license
>>> entire work under GPL-2.0.
>>>
>>> This also adds previously undocumented 32 kHz clock output modelled as
>>> regulators.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>>
>> Thanks for your patch, which is now commit 1d2104f21618a4ce
>> ("regulator: dt-bindings: maxim,max8997: convert to dtschema").
>>
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/regulator/maxim,max8997.yaml
>>
>>> +if:
>>> +  anyOf:
>>> +    - required:
>>> +        - max8997,pmic-buck1-uses-gpio-dvs
>>> +    - required:
>>> +        - max8997,pmic-buck2-uses-gpio-dvs
>>> +    - required:
>>> +        - max8997,pmic-buck5-uses-gpio-dvs
>>> +then:
>>> +  properties:
>>> +    max8997,pmic-buck1-dvs-voltage:
>>> +      minItems: 8
>>> +      maxItems: 8
>>> +    max8997,pmic-buck2-dvs-voltage:
>>> +      minItems: 8
>>> +      maxItems: 8
>>> +    max8997,pmic-buck5-dvs-voltage:
>>> +      minItems: 8
>>> +      maxItems: 8
>>
>> The above doesn't seem to work as expected...
>>
> 
> Thanks for pointing this out. I am pretty sure I tested it and it worked
> fine (as it is not an obvious code), so I wonder what changed... maybe I
> was using slightly older dt-schema?

I think I found the cause - not that long time ago, the dtschema started
parsing arrays in a different way.

It seems that "minItems" must be now under "items:" part for
uint32-array. I think this was recent Rob's work.

I sent a fix.

Best regards,
Krzysztof