linux-kernel - Re: [PATCH v2 2/2] serial: 8250: Report which option to enable for blacklisted PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2203310125350.44113@angie.orcam.me.uk>
Date:   Thu, 31 Mar 2022 08:12:00 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
cc:     Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] serial: 8250: Report which option to enable for
 blacklisted PCI devices

On Sun, 27 Feb 2022, Maciej W. Rozycki wrote:

> > > We don't do this for any other driver subsystem, so why is it really
> > > needed?  What is so special about this driver that distros can't
> > > just enable all of the drivers and all is good?  What is keeping those
> > > drivers fromb eing enabled?
> > 
> >  My justification is we have a supposedly generic PCI 8250 UART driver, 
> > except it explicitly and silently refuses to handle a handful of devices 
> > chosen by their PCI IDs based on that they may have extra features, even 
> > though they are otherwise fully compatible with a generic 8250.
> 
>  Actually as it happens we do have a precedent too, as here's what I have 
> just spotted on my laptop by chance when hibernating:
> 
> psmouse serio1: synaptics: The touchpad can support a better bus than the too old PS/2 protocol. Make sure MOUSE_PS2_SYNAPTICS_SMBUS and RMI4_SMB are enabled to get a better touchpad experience.
> 
> (with a distribution kernel, so clearly whoever packaged that has not 
> enabled what might be needed).  Someone else wanted to be helpful too as 
> it seems.

 I have now posted v3 with these clarifications included in the change 
descriptions.  Please review.

  Maciej