| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Mar 2022 09:36:24 +0200
From: Cédric Le Goater <clg@...d.org>
To: Pratyush Yadav <p.yadav@...com>
CC: <linux-spi@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
Mark Brown <broonie@...nel.org>,
Tudor Ambarus <tudor.ambarus@...rochip.com>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
<linux-aspeed@...ts.ozlabs.org>, Joel Stanley <joel@....id.au>,
Andrew Jeffery <andrew@...id.au>,
Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>,
<devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, Tao Ren <rentao.bupt@...il.com>,
Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v4 02/11] dt-bindings: spi: Add Aspeed SMC controllers
device tree binding
Hello Pratyush,
On 3/30/22 21:19, Pratyush Yadav wrote:
> On 25/03/22 11:08AM, Cédric Le Goater wrote:
>> The "interrupt" property is optional because it is only necessary for
>> controllers supporting DMAs (Not implemented yet in the new driver).
>>
>> Cc: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
>> Tested-by: Joel Stanley <joel@....id.au>
>> Tested-by: Tao Ren <rentao.bupt@...il.com>
>> Reviewed-by: Joel Stanley <joel@....id.au>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> Signed-off-by: Cédric Le Goater <clg@...d.org>
>> ---
>> .../bindings/spi/aspeed,ast2600-fmc.yaml | 87 +++++++++++++++++++
>> MAINTAINERS | 9 ++
>> 2 files changed, 96 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
>> new file mode 100644
>> index 000000000000..e16bbcd38560
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
>> @@ -0,0 +1,87 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/spi/aspeed,ast2600-fmc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Aspeed SMC controllers bindings
>> +
>> +maintainers:
>> + - Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
>> + - Cédric Le Goater <clg@...d.org>
>> +
>> +description: |
>> + This binding describes the Aspeed Static Memory Controllers (FMC and
>> + SPI) of the AST2400, AST2500 and AST2600 SOCs.
>> +
>> +allOf:
>> + - $ref: "spi-controller.yaml#"
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - aspeed,ast2600-fmc
>> + - aspeed,ast2600-spi
>> + - aspeed,ast2500-fmc
>> + - aspeed,ast2500-spi
>> + - aspeed,ast2400-fmc
>> + - aspeed,ast2400-spi
>> +
>> + reg:
>> + items:
>> + - description: registers
>> + - description: memory mapping
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> +patternProperties:
>> + "@[0-9a-f]+":
>> + type: object
>> +
>> + properties:
>> + spi-rx-bus-width:
>> + enum: [1, 2, 4]
>
> No need for this. It should already be taken care of by
> spi-peripheral-props.yaml
So we could drop the whole 'patternProperties' section ?
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/interrupt-controller/aspeed-scu-ic.h>
>> + #include <dt-bindings/clock/ast2600-clock.h>
>> +
>> + spi@...20000 {
>> + reg = <0x1e620000 0xc4>, <0x20000000 0x10000000>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "aspeed,ast2600-fmc";
>> + clocks = <&syscon ASPEED_CLK_AHB>;
>> + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
>
> Nitpick: Add a blank line here
>
>> + flash@0 {
>> + reg = < 0 >;
>> + compatible = "jedec,spi-nor";
>> + spi-max-frequency = <50000000>;
>> + spi-rx-bus-width = <2>;
>> + };
>
> and here
>
>> + flash@1 {
>> + reg = < 1 >;
>> + compatible = "jedec,spi-nor";
>> + spi-max-frequency = <50000000>;
>> + spi-rx-bus-width = <2>;
>> + };
>
> and here. Looks a bit nicer.
Thanks for the comments, I will provide the cleanups in v5.
C.
>
>> + flash@2 {
>> + reg = < 2 >;
>> + compatible = "jedec,spi-nor";
>> + spi-max-frequency = <50000000>;
>> + spi-rx-bus-width = <2>;
>> + };
>> + };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ea9d74b6236f..7d5f81dcd837 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3021,6 +3021,15 @@ S: Maintained
>> F: Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml
>> F: drivers/mmc/host/sdhci-of-aspeed*
>>
>> +ASPEED SMC SPI DRIVER
>> +M: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
>> +M: Cédric Le Goater <clg@...d.org>
>> +L: linux-aspeed@...ts.ozlabs.org (moderated for non-subscribers)
>> +L: openbmc@...ts.ozlabs.org (moderated for non-subscribers)
>> +L: linux-spi@...r.kernel.org
>> +S: Maintained
>> +F: Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
>> +
>> ASPEED VIDEO ENGINE DRIVER
>> M: Eddie James <eajames@...ux.ibm.com>
>> L: linux-media@...r.kernel.org
>> --
>> 2.34.1
>>
>
Powered by blists - more mailing lists