[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5dea78a0-83ed-c016-35c6-637c8a445005@linaro.org>
Date: Thu, 31 Mar 2022 11:38:16 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>,
ulf.hansson@...aro.org, robh+dt@...nel.org, krzk+dt@...nel.org,
huziji@...vell.com, andrew@...n.ch, gregory.clement@...tlin.com,
sebastian.hesselbarth@...il.com
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 2/2] dt-bindings: mmc: xenon: Convert to JSON schema
On 30/03/2022 09:20, Krzysztof Kozlowski wrote:
> On 30/03/2022 00:05, Chris Packham wrote:
>> Convert the marvell,xenon-sdhci binding to JSON schema. Currently the
>> in-tree dts files don't validate because they use sdhci@ instead of mmc@
>> as required by the generic mmc-controller schema.
>>
>> The compatible "marvell,sdhci-xenon" was not documented in the old
>> binding but it accompanies the of "marvell,armada-3700-sdhci" in the
>> armada-37xx SoC dtsi so this combination is added to the new binding
>> document.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
>> ---
>>
>> Notes:
>> Changes in v5:
>> - Fix silly error in examples
>> Changes in v4:
>> - Add review from Krzysztof
>> - Squash in addition of marvell,sdhci-xenon with an explanation in the
>> commit message
>> Changes in v3:
>> - Don't accept ap807 without ap806
>> - Add ref: string for pad-type
>> Changes in v2:
>> - Update MAINTAINERS entry
>> - Incorporate feedback from Krzysztof
>>
>> .../bindings/mmc/marvell,xenon-sdhci.txt | 173 -----------
>> .../bindings/mmc/marvell,xenon-sdhci.yaml | 275 ++++++++++++++++++
>> MAINTAINERS | 2 +-
>> 3 files changed, 276 insertions(+), 174 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt
>> create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml
>>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
Oh, this should be only one review tag. Preferably @linaro.org. Sorry
for the noise.
Best regards,
Krzysztof
Powered by blists - more mailing lists