linux-kernel - Re: [PATCH] media: mc: delete redundant code in __media_device_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ba0e090-c1c0-b237-73ac-3eb4b007f5f4@gmail.com>
Date:   Thu, 31 Mar 2022 09:52:47 +0800
From:   Hangyu Hua <hbh25y@...il.com>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: mc: delete redundant code in
 __media_device_unregister_entity

On 2022/3/30 19:05, Sakari Ailus wrote:
> On Thu, Mar 24, 2022 at 03:47:10PM +0200, Laurent Pinchart wrote:
>> Hi Hangyu,
>>
>> Thank you for the patch.
>>
>> On Thu, Mar 24, 2022 at 06:27:52PM +0800, Hangyu Hua wrote:
>>> media_gobj_destroy has already set graph_obj.mdev to NULL. There is no need to
>>> set it again.
>>>
>>> Signed-off-by: Hangyu Hua <hbh25y@...il.com>
>>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>>
>>> ---
>>>   drivers/media/mc/mc-device.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
>>> index cf5e459b1d96..7727c619043e 100644
>>> --- a/drivers/media/mc/mc-device.c
>>> +++ b/drivers/media/mc/mc-device.c
>>> @@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)
>>>   
>>>   	/* invoke entity_notify callbacks to handle entity removal?? */
>>>   
>>> -	entity->graph_obj.mdev = NULL;
> 
> Removed the extra newline above, too. Applied.
> 
> Please run scripts/checkpatch.pl on the patches, too.

Thanks. I will make a v2 with this change.
> 
>>>   }
>>>   
>>>   /**
>>
>> -- 
>> Regards,
>>
>> Laurent Pinchart
>