linux-kernel - Re: [PATCH] staging: gdm724x: Fix Duplication of Side Effects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YkWRort8Fsnndxf2@kroah.com>
Date:   Thu, 31 Mar 2022 13:33:54 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
Cc:     outreachy@...ts.linux.dev, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gdm724x: Fix Duplication of Side Effects

On Thu, Mar 31, 2022 at 12:18:49PM +0200, Alaa Mohamed wrote:
> Fix Duplication of Side Effects for GDM_TTY_READY(gdm) macro
> reported by checkpatch
> "CHECK: Macro argument reuse 'gdm' - possible side-effects?"

There are no such side-effects here, sorry.  Please always evaluate the
code to see what it does, checkpatch sometimes gets it wrong.

thanks,

greg k-h