linux-kernel - Re: arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_l1d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 31 Mar 2022 13:51:37 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Borislav Petkov <bp@...e.de>
Subject: Re: arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_l1d_flush()+0xb5:
 missing int3 after ret

On Thu, Mar 31, 2022 at 05:14:37PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   787af64d05cd528aac9ad16752d11bb1c6061bb9
> commit: e463a09af2f0677b9485a7e8e4e70b396b2ffb6f x86: Add straight-line-speculation mitigation
> date:   4 months ago
> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220331/202203311730.Io171QCN-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e463a09af2f0677b9485a7e8e4e70b396b2ffb6f
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout e463a09af2f0677b9485a7e8e4e70b396b2ffb6f
>         # save the config file to linux build tree
>         mkdir build_dir
>         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/ samples/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_l1d_flush()+0xb5: missing int3 after ret
>    arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_l1d_flush()+0xf2: missing int3 after ret
> >> arch/x86/kvm/vmx/vmx.o: warning: objtool: vmx_update_host_rsp()+0x2f: missing int3 after ret
> --
> >> arch/x86/kvm/x86.o: warning: objtool: kvm_spurious_fault()+0x34: missing int3 after ret
> --
>    arch/x86/xen/enlighten_pv.c:1181:34: warning: no previous prototype for 'xen_start_kernel' [-Wmissing-prototypes]
>     1181 | asmlinkage __visible void __init xen_start_kernel(void)
>          |                                  ^~~~~~~~~~~~~~~~
> >> arch/x86/xen/enlighten_pv.o: warning: objtool: xenpv_exc_debug()+0x46: missing int3 after ret
>    arch/x86/xen/enlighten_pv.o: warning: objtool: xenpv_exc_debug()+0x32: missing int3 after ret
> >> arch/x86/xen/enlighten_pv.o: warning: objtool: xenpv_exc_machine_check()+0x46: missing int3 after ret
>    arch/x86/xen/enlighten_pv.o: warning: objtool: xenpv_exc_machine_check()+0x32: missing int3 after ret
> --
> >> arch/x86/kernel/kvm.o: warning: objtool: __raw_callee_save___kvm_vcpu_is_preempted()+0x12: missing int3 after ret
> --
> >> arch/x86/mm/fault.o: warning: objtool: exc_page_fault()+0x124: missing int3 after ret
>    arch/x86/mm/fault.o: warning: objtool: exc_page_fault()+0x154: missing int3 after ret
> --
> >> arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_init_x86_64()+0x3a: missing int3 after ret
> >> arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_blocks_x86_64()+0xf2: missing int3 after ret
> >> arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_emit_x86_64()+0x37: missing int3 after ret
> >> arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: __poly1305_block()+0x6d: missing int3 after ret
> >> arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: __poly1305_init_avx()+0x1e8: missing int3 after ret
> >> arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_blocks_avx()+0x18a: missing int3 after ret
>    arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_blocks_avx()+0xaf8: missing int3 after ret
> >> arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_emit_avx()+0x99: missing int3 after ret
> >> arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_blocks_avx2()+0x18a: missing int3 after ret
>    arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_blocks_avx2()+0x776: missing int3 after ret
> >> arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_blocks_avx512()+0x18a: missing int3 after ret
>    arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_blocks_avx512()+0x796: missing int3 after ret
>    arch/x86/crypto/poly1305-x86_64-cryptogams.o: warning: objtool: poly1305_blocks_avx512()+0x10bd: missing int3 after ret
> --
> >> arch/x86/kernel/cpu/mce/core.o: warning: objtool: mce_wrmsrl.constprop.0()+0x6b: missing int3 after ret
>    arch/x86/kernel/cpu/mce/core.o: warning: objtool: mce_wrmsrl.constprop.0()+0x3e: missing int3 after ret
> >> arch/x86/kernel/cpu/mce/core.o: warning: objtool: exc_machine_check()+0x12a: missing int3 after ret
> >> arch/x86/kernel/cpu/mce/core.o: warning: objtool: noist_exc_machine_check()+0xfb: missing int3 after ret
>    arch/x86/kernel/cpu/mce/core.o: warning: objtool: noist_exc_machine_check()+0x121: missing int3 after ret
> --
> >> samples/ftrace/ftrace-direct-multi.o: warning: objtool: my_tramp()+0x10: missing int3 after ret

I think I sorted all those with these 5 patches here:

  https://lkml.kernel.org/r/20220322114809.381992456@infradead.org

3 of those are currently in the crypto tree, and I'll queue the two
remaining post -rc1.