linux-kernel - Re: [PATCH v2] block: use dedicated list iterator variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <164872836394.7852.9344079162179392052.b4-ty@kernel.dk>
Date:   Thu, 31 Mar 2022 06:06:03 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Jakob Koschel <jakobkoschel@...il.com>
Cc:     "Bos, H.J." <h.j.bos@...nl>, linux-kernel@...r.kernel.org,
        Brian Johannesmeyer <bjohannesmeyer@...il.com>,
        Mike Rapoport <rppt@...nel.org>, linux-block@...r.kernel.org,
        Bart Van Assche <bvanassche@....org>,
        Cristiano Giuffrida <c.giuffrida@...nl>
Subject: Re: [PATCH v2] block: use dedicated list iterator variable

On Thu, 31 Mar 2022 11:12:18 +0200, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
> 
> [...]

Applied, thanks!

[1/1] block: use dedicated list iterator variable
      commit: 4a3b666e0ea977dd40adb56c37a91370f76fa19e

Best regards,
-- 
Jens Axboe