linux-kernel - Re: [RFC PATCH 5/5] ASoC: Add macaudio machine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Mar 2022 14:16:56 +0200
From:   Martin Povišer <povik@...ebit.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Martin Povišer <povik+lin@...ebit.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mark Kettenis <kettenis@...nbsd.org>,
        Hector Martin <marcan@...can.st>,
        Sven Peter <sven@...npeter.dev>
Subject: Re: [RFC PATCH 5/5] ASoC: Add macaudio machine driver


> On 31. 3. 2022, at 14:08, Martin Povišer <povik@...ebit.org> wrote:
> 
>> 
>> On 31. 3. 2022, at 13:59, Mark Brown <broonie@...nel.org> wrote:
>> 
>> On Thu, Mar 31, 2022 at 02:04:49AM +0200, Martin Povišer wrote:
>> 
>>> --- /dev/null
>>> +++ b/sound/soc/apple/macaudio.c
>>> @@ -0,0 +1,597 @@
>>> +// SPDX-License-Identifier: GPL-2.0-only
>>> +/*
>>> + * ASoC machine driver for Apple Silicon Macs
>>> + *

(snip)

>>> +/*
>>> + * Maybe this could be a general ASoC function?
>>> + */
>>> +static void snd_soc_kcontrol_set_strval(struct snd_soc_card *card,
>>> +				struct snd_kcontrol *kcontrol, const char *strvalue)
>> 
>> No, we should not be setting user visible control values from the
>> kernel.  This shouldn't be a machine driver function either.  What are
>> you trying to accomplish here?
> 
> See above.
> 
> Martin

One thing I didn’t point out. The controls we are setting here are not
visible from userspace. That’s the point of the ‘filter’ card method
I am trying to establish in the other commit. With it, the card decides
which controls are okay to be exported and which should be hidden.

Here we are only setting hidden controls.

Martin