linux-kernel - [PATCH v2] media: mc: delete redundant code in __media_device_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 31 Mar 2022 10:06:06 +0800
From:   Hangyu Hua <hbh25y@...il.com>
To:     sakari.ailus@...ux.intel.com, laurent.pinchart@...asonboard.com,
        mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hangyu Hua <hbh25y@...il.com>
Subject: [PATCH v2] media: mc: delete redundant code in __media_device_unregister_entity

media_gobj_destroy has already set graph_obj.mdev to NULL. There is no need
to set it again.

Signed-off-by: Hangyu Hua <hbh25y@...il.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
---

v2: Remove an extra newline.

 drivers/media/mc/mc-device.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
index cf5e459b1d96..585816e0901c 100644
--- a/drivers/media/mc/mc-device.c
+++ b/drivers/media/mc/mc-device.c
@@ -604,8 +604,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)
 	media_gobj_destroy(&entity->graph_obj);
 
 	/* invoke entity_notify callbacks to handle entity removal?? */
-
-	entity->graph_obj.mdev = NULL;
 }
 
 /**
-- 
2.25.1