linux-kernel - Re: [PATCH] [RFC] Documentation/process: Add testing section to tip handbook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkWgv1yBGtcAbPVj@zn.tnic>
Date:   Thu, 31 Mar 2022 14:38:23 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Dave Hansen <dave.hansen@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        Borislav Petkov <bp@...e.de>,
        Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH] [RFC] Documentation/process: Add testing section to tip
 handbook

On Mon, Mar 14, 2022 at 11:35:52AM -0700, Dave Hansen wrote:
> From: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> The kernel has a wide variety of debugging options to help catch
> and squash bugs.  However, new debugging is added all the time and
> the existing options can be hard to find.
> 
> Add a list of debugging options which tip maintainers expect to be
> used to test contributions.
> 
> This should make it easier for contributors to test their code and
> find issues before submission.
> 
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: Jonathan Corbet <corbet@....net>
> Cc: Borislav Petkov <bp@...e.de>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: x86@...nel.org
> Cc: linux-doc@...r.kernel.org
> ---
>  Documentation/process/maintainer-tip.rst | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/Documentation/process/maintainer-tip.rst b/Documentation/process/maintainer-tip.rst
> index c74f4a81588b..75f86b0f1cf0 100644
> --- a/Documentation/process/maintainer-tip.rst
> +++ b/Documentation/process/maintainer-tip.rst
> @@ -437,6 +437,30 @@ in a private repository which allows interested people to easily pull the
>  series for testing. The usual way to offer this is a git URL in the cover
>  letter of the patch series.
>  
> +Testing
> +^^^^^^^
> +
> +Code should be tested before submitting to the tip maintainers.  Anything
> +other than minor changes should be built, booted and tested with the
> +following set of comprehensive (and heavyweight) set of kernel debugging
> +options enabled.
> +
> +	CONFIG_X86_DEBUG_FPU=y
> +	CONFIG_LOCK_STAT=y
> +	CONFIG_DEBUG_VM=y
> +	CONFIG_DEBUG_VM_VMACACHE=y
> +	CONFIG_DEBUG_VM_RB=y
> +	CONFIG_DEBUG_SLAB=y
> +	CONFIG_DEBUG_KMEMLEAK=y
> +	CONFIG_DEBUG_PAGEALLOC=y
> +	CONFIG_SLUB_DEBUG_ON=y
> +	CONFIG_KMEMCHECK=y
> +	CONFIG_DEBUG_OBJECTS_ENABLE_DEFAULT=y
> +	CONFIG_GCOV_KERNEL=y
> +	CONFIG_LOCKDEP=y
> +	CONFIG_PROVE_LOCKING=y
> +	CONFIG_SCHEDSTATS=y
> +	CONFIG_VMLINUX_VALIDATION=y

It would be cool if there were a command I can run so that I can enable
all those. Example:

$ grep CONFIG_VMLINUX_VALIDATION .config
$ ./scripts/config --enable CONFIG_VMLINUX_VALIDATION
$ grep CONFIG_VMLINUX_VALIDATION .config
CONFIG_VMLINUX_VALIDATION=y
$ make oldconfig
#
# configuration written to .config
#
$ grep CONFIG_VMLINUX_VALIDATION .config
$

Needs other options.

Maybe you could create a .config snippet which we can merge
with scripts/kconfig/merge_config.sh... or maybe start from
arch/x86/configs/x86_64_defconfig, add all those and call it

arch/x86/configs/x86_64_testconfig

or so.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette