linux-kernel - Re: [PATCH] staging: rtl8723bs: Fix No space before tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220331133744.lypehhmz2wxngvzl@bryanbrattlof.com>
Date:   Thu, 31 Mar 2022 08:37:44 -0500
From:   Bryan Brattlof <bb@...com>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
CC:     <outreachy@...ts.linux.dev>, <gregkh@...uxfoundation.org>,
        <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: Fix No space before tabs

Hi Alaa!

Thank you for the patch

On March 31, 2022 thus sayeth Alaa Mohamed:
> Fix "WARNING: please, no space before tabs"
> reported by checkpatch
> 
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 54 +++++++++++-----------
>  1 file changed, 27 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 3d3c77273026..06e727ce9cc2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -100,7 +100,7 @@ u8 PwrState)
>  u16
>  Efuse_GetCurrentSize(
>  	struct adapter *padapter,
> -	u8 	efuseType,
> +	u8	efuseType,
>  	bool		bPseudoTest)
>  {
>  	return padapter->HalFunc.EfuseGetCurrentSize(padapter, efuseType,
> @@ -124,29 +124,29 @@ Efuse_CalculateWordCnts(u8 word_en)
>  }
>  
>  /*  */
> -/* 	Description: */
> -/* 		1. Execute E-Fuse read byte operation according as map offset and */
> -/* 		    save to E-Fuse table. */
> -/* 		2. Referred from SD1 Richard. */
> +/* Description: */
> +/*		1. Execute E-Fuse read byte operation according as map offset and */
> +/*			save to E-Fuse table. */
> +/*		2. Referred from SD1 Richard. */
>  /*  */
> -/* 	Assumption: */
> -/* 		1. Boot from E-Fuse and successfully auto-load. */
> -/* 		2. PASSIVE_LEVEL (USB interface) */
> +/* Assumption: */
> +/*		1. Boot from E-Fuse and successfully auto-load. */
> +/*		2. PASSIVE_LEVEL (USB interface) */
>  /*  */
> -/* 	Created by Roger, 2008.10.21. */
> +/* Created by Roger, 2008.10.21. */
>  /*  */
> -/* 	2008/12/12 MH	1. Reorganize code flow and reserve bytes. and add description. */
> -/* 					2. Add efuse utilization collect. */
> -/* 	2008/12/22 MH	Read Efuse must check if we write section 1 data again!!! Sec1 */
> -/* 					write addr must be after sec5. */
> +/* 2008/12/12 MH	1. Reorganize code flow and reserve bytes. and add description. */
> +/*					2. Add efuse utilization collect. */
> +/* 2008/12/22 MH	Read Efuse must check if we write section 1 data again!!! Sec1 */
> +/*					write addr must be after sec5. */
>  /*  */
>

I'm wondering if it would be OK if we removed the change history and 
tried to align the indentation a little. (This may need to be multiple 
patches depending on how everyone else feels)

It may help if we converted the comments into one block. eg:

   /* ... */
   /* ... */

to

  /*
   * ...
   * ...
   */

thank you again for the patch
~Bryan