linux-kernel - Re: [PATCH] scsi: sd: call device_del() if device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Mar 2022 11:26:22 -0400
From:   Wenchao Hao <haowenchao@...wei.com>
To:     <fmdefrancesco@...il.com>
CC:     <axboe@...nel.dk>, <dan.carpenter@...cle.com>,
        <jejb@...ux.ibm.com>, <linux-block@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <martin.petersen@...cle.com>,
        <syzbot+f08c77040fa163a75a46@...kaller.appspotmail.com>,
        <syzkaller-bugs@...glegroups.com>, <linfeilong@...wei.com>,
        <haowenchao@...wei.com>
Subject: Re: [PATCH] scsi: sd: call device_del() if device_add_disk() fails

I do not think it's necessary to call device_del() on this path. If the device
has been added, put_device() would delete it from sysfs. So the origin error
handle is ok with me.