linux-kernel - Re: [PATCH v2] staging: rtl8723bs: place constants on the right side of tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220331151551.GR3293@kadam>
Date:   Thu, 31 Mar 2022 18:15:51 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Sevinj Aghayeva <sevinj.aghayeva@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH v2] staging: rtl8723bs: place constants on the right side
 of tests

On Thu, Mar 31, 2022 at 10:27:43AM -0400, Sevinj Aghayeva wrote:
> On Thu, Mar 31, 2022 at 10:15 AM Dan Carpenter <dan.carpenter@...cle.com> wrote:
> >
> > On Thu, Mar 31, 2022 at 08:26:18AM -0400, Sevinj Aghayeva wrote:
> > > Adhere to Linux kernel coding style.
> > >
> > > Reported by checkpatch:
> > >
> > > WARNING: Comparisons should place the constant on the right side of the test
> > >
> > > Signed-off-by: Sevinj Aghayeva <sevinj.aghayeva@...il.com>
> > > ---
> > >
> > > v1 -> v2: Missed one case of constant being placed on the left. Now
> > > checkpath reports no such warnings for this file.
> >
> > You need to send a reply to the original email "Hi, please ignore this
> > one, I spotted another line I want to clean up" so that Greg does not
> > apply it first before reading this one.
> 
> Got it, thanks! Will do so in the future.
> 

No problem, I will handle this one for you.

regards,
dan carpenter