| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Apr 2022 17:28:11 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Charles Keepax <ckeepax@...nsource.cirrus.com>,
Linus Walleij <linus.walleij@...aro.org>,
Tony Lindgren <tony@...mide.com>,
Yunfei Dong <yunfei.dong@...iatek.com>,
- <patches@...nsource.cirrus.com>, linux-media@...r.kernel.org,
alsa-devel@...a-project.org, linux-gpio@...r.kernel.org,
linux-pm@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: Fix 'enum' lists with duplicate entries
Hi,
On Fri, Apr 01, 2022 at 09:12:47AM -0500, Rob Herring wrote:
> There's no reason to list the same value twice in an 'enum'. Fix all the
> occurrences in the tree. A meta-schema change will catch future ones.
>
> Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Jonathan Hunter <jonathanh@...dia.com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Charles Keepax <ckeepax@...nsource.cirrus.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: Tony Lindgren <tony@...mide.com>
> Cc: Yunfei Dong <yunfei.dong@...iatek.com>
> Cc: - <patches@...nsource.cirrus.com>
> Cc: linux-media@...r.kernel.org
> Cc: alsa-devel@...a-project.org
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
Acked-by: Sebastian Reichel <sebastian.reichel@...labora.com>
-- Sebastian
> There's also one other occurrence in snps,dwmac.yaml I didn't fix as
> there's a patch[1] for it which prompted this patch.
>
> Rob
>
> [1] https://lore.kernel.org/r/20220401030847epcms1p8cf7a8e1d8cd7d325dacf30f78da36328@epcms1p8
>
> .../bindings/arm/tegra/nvidia,tegra20-pmc.yaml | 1 -
> Documentation/devicetree/bindings/bus/ti-sysc.yaml | 1 -
> .../bindings/media/mediatek,vcodec-encoder.yaml | 1 -
> .../devicetree/bindings/pinctrl/cirrus,madera.yaml | 11 +++++------
> .../devicetree/bindings/power/supply/bq2415x.yaml | 1 -
> 5 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml
> index 0afec83cc723..564ae6aaccf7 100644
> --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml
> +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-pmc.yaml
> @@ -13,7 +13,6 @@ maintainers:
> properties:
> compatible:
> enum:
> - - nvidia,tegra20-pmc
> - nvidia,tegra20-pmc
> - nvidia,tegra30-pmc
> - nvidia,tegra114-pmc
> diff --git a/Documentation/devicetree/bindings/bus/ti-sysc.yaml b/Documentation/devicetree/bindings/bus/ti-sysc.yaml
> index bd40213302da..fced4082b047 100644
> --- a/Documentation/devicetree/bindings/bus/ti-sysc.yaml
> +++ b/Documentation/devicetree/bindings/bus/ti-sysc.yaml
> @@ -34,7 +34,6 @@ properties:
> oneOf:
> - items:
> - enum:
> - - ti,sysc-omap2
> - ti,sysc-omap2
> - ti,sysc-omap4
> - ti,sysc-omap4-simple
> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> index e7b65a91c92c..df7df06c378f 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml
> @@ -106,7 +106,6 @@ allOf:
> enum:
> - mediatek,mt8173-vcodec-enc
> - mediatek,mt8192-vcodec-enc
> - - mediatek,mt8173-vcodec-enc
>
> then:
> properties:
> diff --git a/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml b/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml
> index 8a90d8273767..6bd42e43cdab 100644
> --- a/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml
> @@ -48,13 +48,12 @@ properties:
> Name of one pin group to configure.
> enum: [ aif1, aif2, aif3, aif4, mif1, mif2, mif3, pdmspk1,
> pdmspk2, dmic4, dmic5, dmic6, gpio1, gpio2, gpio3,
> - gpio4, gpio5, gpio6, gpio7, gpio7, gpio8, gpio9,
> + gpio4, gpio5, gpio6, gpio7, gpio8, gpio9,
> gpio10, gpio11, gpio12, gpio13, gpio14, gpio15,
> - gpio16, gpio17, gpio17, gpio18, gpio19, gpio20,
> - gpio21, gpio22, gpio23, gpio24, gpio25, gpio26,
> - gpio27, gpio27, gpio28, gpio29, gpio30, gpio31,
> - gpio32, gpio33, gpio34, gpio35, gpio36, gpio37,
> - gpio37, gpio38, gpio39 ]
> + gpio16, gpio17, gpio18, gpio19, gpio20, gpio21,
> + gpio22, gpio23, gpio24, gpio25, gpio26, gpio27,
> + gpio28, gpio29, gpio30, gpio31, gpio32, gpio33,
> + gpio34, gpio35, gpio36, gpio37, gpio38, gpio39 ]
>
> function:
> description:
> diff --git a/Documentation/devicetree/bindings/power/supply/bq2415x.yaml b/Documentation/devicetree/bindings/power/supply/bq2415x.yaml
> index f8461f06e6f4..118cf484cc69 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq2415x.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/bq2415x.yaml
> @@ -16,7 +16,6 @@ allOf:
> properties:
> compatible:
> enum:
> - - ti,bq24150
> - ti,bq24150
> - ti,bq24150a
> - ti,bq24151
> --
> 2.32.0
>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists