linux-kernel - RE: [PATCH v2 1/5] fpga: zynq: Fix incorrect variable type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Apr 2022 15:45:27 +0000
From:   Nava kishore Manne <navam@...inx.com>
To:     Tom Rix <trix@...hat.com>, "mdf@...nel.org" <mdf@...nel.org>,
        "hao.wu@...el.com" <hao.wu@...el.com>,
        "yilun.xu@...el.com" <yilun.xu@...el.com>,
        Michal Simek <michals@...inx.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>, git <git@...inx.com>
Subject: RE: [PATCH v2 1/5] fpga: zynq: Fix incorrect variable type

Hi Tom,

	Thanks for providing the review comments.
Please find my response inline.

> -----Original Message-----
> From: Tom Rix <trix@...hat.com>
> Sent: Saturday, March 26, 2022 10:24 PM
> To: Nava kishore Manne <navam@...inx.com>; mdf@...nel.org;
> hao.wu@...el.com; yilun.xu@...el.com; Michal Simek
> <michals@...inx.com>; linux-fpga@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; git
> <git@...inx.com>
> Subject: Re: [PATCH v2 1/5] fpga: zynq: Fix incorrect variable type
> 
> 
> On 3/22/22 1:21 AM, Nava kishore Manne wrote:
> > zynq_fpga_has_sync () API is expecting "u8 *" but the formal parameter
> > that was passed is of type "const char *".
> > To fix this issue cast the const char pointer to u8 pointer.
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@...inx.com>
> > ---
> > Changes for v2:
> > 		-None.
> >
> >   drivers/fpga/zynq-fpga.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index
> > 426aa34c6a0d..12f644e79e91 100644
> > --- a/drivers/fpga/zynq-fpga.c
> > +++ b/drivers/fpga/zynq-fpga.c
> > @@ -275,7 +275,7 @@ static int zynq_fpga_ops_write_init(struct
> > fpga_manager *mgr,
> >
> >   	/* don't globally reset PL if we're doing partial reconfig */
> >   	if (!(info->flags & FPGA_MGR_PARTIAL_RECONFIG)) {
> > -		if (!zynq_fpga_has_sync(buf, count)) {
> > +		if (!zynq_fpga_has_sync((u8 *)buf, count)) {
> 
> Instead of casting, change the signature of zynq_fpga_has_sync to use const
> char * over const *u8.
> 
> Also please review the implementation of zynq_fpga_has_sync.
> 
I agree, will fix in v3.
> The comments says 'It must start with .. ' but the loop looks over the whole
> buffer
> 
Will correct the API description in v3.

Regards,
Navakishore.