linux-kernel - [PATCH] habanalabs: Elide a warning on 32-bit targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri,  1 Apr 2022 09:39:09 -0700
From:   Palmer Dabbelt <palmer@...osinc.com>
To:         linux-riscv@...ts.infradead.org
Cc:     ogabbay@...nel.org, Arnd Bergmann <arnd@...db.de>,
        Greg KH <gregkh@...uxfoundation.org>, ynudelman@...ana.ai,
        obitton@...ana.ai, fkassabri@...ana.ai, daniel.vetter@...ll.ch,
        ttayar@...ana.ai, sozeri@...ana.ai, bjauhari@...ana.ai,
        linux-kernel@...r.kernel.org, Palmer Dabbelt <palmer@...osinc.com>
Subject: [PATCH] habanalabs: Elide a warning on 32-bit targets

From: Palmer Dabbelt <palmer@...osinc.com>

This double-cast pattern looks a bit awkward, but it already exists
elsewhere in the driver.  Without this patch I get

drivers/misc/habanalabs/common/memory.c: In function ‘alloc_device_memory’:
drivers/misc/habanalabs/common/memory.c:153:49: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  153 |                                                 (u64) gen_pool_dma_alloc_align(vm->dram_pg_pool,
      |                                                 ^

which ends up promoted to a build error in my test setup.

Signed-off-by: Palmer Dabbelt <palmer@...osinc.com>

---

I don't know anything about this driver, I'm just pattern-matching the
warning away.
---
 drivers/misc/habanalabs/common/memory.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c
index e008d82e4ba3..f1fc79c1fc10 100644
--- a/drivers/misc/habanalabs/common/memory.c
+++ b/drivers/misc/habanalabs/common/memory.c
@@ -150,12 +150,12 @@ static int alloc_device_memory(struct hl_ctx *ctx, struct hl_mem_in *args,
 		for (i = 0 ; i < num_pgs ; i++) {
 			if (is_power_of_2(page_size))
 				phys_pg_pack->pages[i] =
-						(u64) gen_pool_dma_alloc_align(vm->dram_pg_pool,
-										page_size, NULL,
-										page_size);
+						(u64) (uintptr_t) gen_pool_dma_alloc_align(vm->dram_pg_pool,
+											   page_size, NULL,
+											   page_size);
 			else
-				phys_pg_pack->pages[i] = (u64) gen_pool_alloc(vm->dram_pg_pool,
-										page_size);
+				phys_pg_pack->pages[i] = (u64) (uintptr_t) gen_pool_alloc(vm->dram_pg_pool,
+											  page_size);
 			if (!phys_pg_pack->pages[i]) {
 				dev_err(hdev->dev,
 					"Failed to allocate device memory (out of memory)\n");
-- 
2.34.1