linux-kernel - Re: [PATCH v2 resend 3/3] arm64: mm: Cleanup useless parameters in zone_sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Apr 2022 10:05:16 -0700
From:   Vijay Balakrishna <vijayb@...ux.microsoft.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>, catalin.marinas@....com,
        will@...nel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Cc:     f.fainelli@...il.com
Subject: Re: [PATCH v2 resend 3/3] arm64: mm: Cleanup useless parameters in
 zone_sizes_init()



On 3/31/2022 12:40 AM, Kefeng Wang wrote:
> Directly use max_pfn for max and no one use min, kill them.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>

Looks good.  Reference to dma32_phys_limit in zone_sizes_init() depends 
on what you do with my comment [1].

[1] 
https://lore.kernel.org/all/69c1e722-33ea-95cf-de84-aed3022cb042@linux.microsoft.com/

Reviewed-by: Vijay Balakrishna <vijayb@...ux.microsoft.com>

> ---
>   arch/arm64/mm/init.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 0aafa9181607..80e9ff37b697 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -181,7 +181,7 @@ static phys_addr_t __init max_zone_phys(unsigned int zone_bits)
>   	return min(zone_mask, memblock_end_of_DRAM() - 1) + 1;
>   }
>   
> -static void __init zone_sizes_init(unsigned long min, unsigned long max)
> +static void __init zone_sizes_init(void)
>   {
>   	unsigned long max_zone_pfns[MAX_NR_ZONES]  = {0};
>   #ifdef CONFIG_ZONE_DMA
> @@ -199,7 +199,7 @@ static void __init zone_sizes_init(unsigned long min, unsigned long max)
>   #ifdef CONFIG_ZONE_DMA32
>   	max_zone_pfns[ZONE_DMA32] = PFN_DOWN(dma32_phys_limit);
>   #endif
> -	max_zone_pfns[ZONE_NORMAL] = max;
> +	max_zone_pfns[ZONE_NORMAL] = max_pfn;
>   
>   	free_area_init(max_zone_pfns);
>   }
> @@ -401,7 +401,7 @@ void __init bootmem_init(void)
>   	 * done after the fixed reservations
>   	 */
>   	sparse_init();
> -	zone_sizes_init(min, max);
> +	zone_sizes_init();
>   
>   	/*
>   	 * Reserve the CMA area after arm64_dma_phys_limit was initialised.