linux-kernel - Re: [PATCH] modpost: restore the warning message for missing symbol versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOdnwSnoiP3Vnf-77VGeD6nKc7gLa-nc-ipoCsRBk2m3ueQ@mail.gmail.com>
Date:   Fri, 1 Apr 2022 10:59:25 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mark Brown <broonie@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH] modpost: restore the warning message for missing symbol versions

On Fri, Apr 1, 2022 at 8:56 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> This log message was accidentally chopped off.
>
> I was wondering why this happened, but checking the ML log, Mark
> precisely followed my suggestion [1].
>
> I just used "..." because I was too lazy to type the sentence fully.
> Sorry for the confusion.
>
> [1]: https://lore.kernel.org/all/CAK7LNAR6bXXk9-ZzZYpTqzFqdYbQsZHmiWspu27rtsFxvfRuVA@mail.gmail.com/
>
> Fixes: 4a6795933a89 ("kbuild: modpost: Explicitly warn about unprototyped symbols")
> Cc: Mark Brown <broonie@...nel.org>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

> ---
>
>  scripts/mod/modpost.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index d10f93aac1c8..ed9d056d2108 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -674,7 +674,7 @@ static void handle_modversion(const struct module *mod,
>         unsigned int crc;
>
>         if (sym->st_shndx == SHN_UNDEF) {
> -               warn("EXPORT symbol \"%s\" [%s%s] version ...\n"
> +               warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n"
>                      "Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n",
>                      symname, mod->name, mod->is_vmlinux ? "" : ".ko",
>                      symname);
> --
> 2.32.0
>


-- 
Thanks,
~Nick Desaulniers