linux-kernel - Re: [PATCH] staging: r8188eu: Fix PPPoE tag insertion on big endian systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e68501c-24fd-cfbc-60f2-ec3e277159ab@lwfinger.net>
Date:   Fri, 1 Apr 2022 15:25:49 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix PPPoE tag insertion on big endian
 systems

On 4/1/22 14:25, Guenter Roeck wrote:
> The rest of the code uses htons/ntohs, so I prefer to follow that lead.

You just proved my point. It is hard to get be16_to_cpu() wrong. Sparse will 
flag the error when you use cpu_to_be16() instead. I expect that your 
htons/ntohs problem would also have shown up with Sparse.

Larry