linux-kernel - Re: [PATCH 1/2] drbd: remove usage of list iterator variable after loop for list_for_each_entry_safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164885740219.761778.5044909883791536138.b4-ty@kernel.dk>
Date:   Fri, 01 Apr 2022 17:56:42 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Philipp Reisner <philipp.reisner@...bit.com>,
        Jakob Koschel <jakobkoschel@...il.com>
Cc:     Mike Rapoport <rppt@...nel.org>,
        Lars Ellenberg <lars.ellenberg@...bit.com>,
        drbd-dev@...ts.linbit.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, "Bos, H.J." <h.j.bos@...nl>,
        Cristiano Giuffrida <c.giuffrida@...nl>,
        Brian Johannesmeyer <bjohannesmeyer@...il.com>
Subject: Re: [PATCH 1/2] drbd: remove usage of list iterator variable after loop for list_for_each_entry_safe_from()

On Fri, 1 Apr 2022 00:03:48 +0200, Jakob Koschel wrote:
> In preparation to limit the scope of a list iterator to the list
> traversal loop, use a dedicated pointer to iterate through the list [1].
> 
> Since that variable should not be used past the loop iteration, a
> separate variable is used to 'remember the current location within the
> loop'.
> 
> [...]

Applied, thanks!

[1/2] drbd: remove usage of list iterator variable after loop for list_for_each_entry_safe_from()
      commit: 901aeda62efa21f2eae937bccb71b49ae531be06
[2/2] drbd: remove check of list iterator against head past the loop body
      commit: 2651ee5ae43241831ca63d7158bb2b151a6a0e1f

Best regards,
-- 
Jens Axboe