linux-kernel - RE: [PATCH] pinctrl: samsung: staticize fsd_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000a01d84587$661eb6a0$325c23e0$@samsung.com>
Date:   Fri, 1 Apr 2022 10:44:41 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        "'Tomasz Figa'" <tomasz.figa@...il.com>,
        "'Krzysztof Kozlowski'" <krzk@...nel.org>,
        "'Sylwester Nawrocki'" <s.nawrocki@...sung.com>,
        "'Linus Walleij'" <linus.walleij@...aro.org>,
        "'Ajay Kumar'" <ajaykumar.rs@...sung.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Cc:     "'kernel test robot'" <lkp@...el.com>
Subject: RE: [PATCH] pinctrl: samsung: staticize fsd_pin_ctrl



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
>Sent: Friday, April 1, 2022 1:15 AM
>To: Tomasz Figa <tomasz.figa@...il.com>; Krzysztof Kozlowski
><krzk@...nel.org>; Sylwester Nawrocki <s.nawrocki@...sung.com>; Alim
>Akhtar <alim.akhtar@...sung.com>; Linus Walleij <linus.walleij@...aro.org>;
>Ajay Kumar <ajaykumar.rs@...sung.com>; linux-arm-
>kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org; linux-
>gpio@...r.kernel.org; linux-kernel@...r.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>; kernel test robot
><lkp@...el.com>
>Subject: [PATCH] pinctrl: samsung: staticize fsd_pin_ctrl
>
>struct fsd_pin_ctrl is not used outside of the file, so it can be made
static.  This
>fixes sparse warning:
>
>  drivers/pinctrl/samsung/pinctrl-exynos-arm64.c:773:31: sparse:
>    symbol 'fsd_pin_ctrl' was not declared. Should it be static?
>
>Reported-by: kernel test robot <lkp@...el.com>
>Fixes: 0d1b662c374c ("pinctrl: samsung: add FSD SoC specific data")
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>---

Thanks Krzysztof.

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

> drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
>b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
>index d291819c2f77..cb965cf93705 100644
>--- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
>+++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
>@@ -770,7 +770,7 @@ static const struct samsung_pin_bank_data
>fsd_pin_banks2[] __initconst = {
> 	EXYNOS850_PIN_BANK_EINTN(3, 0x00, "gpq0"),  };
>
>-const struct samsung_pin_ctrl fsd_pin_ctrl[] __initconst = {
>+static const struct samsung_pin_ctrl fsd_pin_ctrl[] __initconst = {
> 	{
> 		/* pin-controller instance 0 FSYS0 data */
> 		.pin_banks	= fsd_pin_banks0,
>--
>2.32.0