linux-kernel - RE: [PATCH v12 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49a391f2636d4bb193b80c301ce0832d@cqplus1.com>
Date:   Fri, 1 Apr 2022 07:17:52 +0000
From:   qinjian[覃健] <qinjian@...lus1.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Rob Herring <robh+dt@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen Boyd" <sboyd@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "Russell King - ARM Linux" <linux@...linux.org.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>
Subject: RE: [PATCH v12 7/9] irqchip: Add Sunplus SP7021 interrupt controller
 driver

> 
> On Thu, Mar 31, 2022 at 10:29 AM Qin Jian <qinjian@...lus1.com> wrote:
> 
> > +#ifdef CONFIG_SMP
> > +static int sp_intc_set_affinity(struct irq_data *d, const struct cpumask *mask, bool force)
> > +{
> > +       return -EINVAL;
> > +}
> > +#endif
> > +
> > +static struct irq_chip sp_intc_chip = {
> > +       .name = "sp_intc",
> > +       .irq_ack = sp_intc_ack_irq,
> > +       .irq_mask = sp_intc_mask_irq,
> > +       .irq_unmask = sp_intc_unmask_irq,
> > +       .irq_set_type = sp_intc_set_type,
> > +#ifdef CONFIG_SMP
> > +       .irq_set_affinity = sp_intc_set_affinity,
> > +#endif
> > +};
> 
> I don't think you need to define an irq_set_affinity() callback at all if you
> just return -EINVAL, all the callers should have a check already. Even
> if you do need the function, I think you can remove the #ifdef, as long
> as the function itself can be built that way.
> 
>       Arnd

Thanks for your comments, I'll remove this empty function.