linux-kernel - Re: [PATCH] dt-bindings: net: snps: remove duplicate name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f02c5fc-5ded-b589-19ca-2b419c4664ab@linaro.org>
Date:   Fri, 1 Apr 2022 09:48:22 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     dj76.yang@...sung.com, "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        전문기 <moonki.jun@...sung.com>
Subject: Re: [PATCH] dt-bindings: net: snps: remove duplicate name

On 01/04/2022 05:08, 양동진 wrote:
> snps,dwmac has duplicated name for loongson,ls2k-dwmac and
> loongson,ls7a-dwmac.

Your "From" name seems to be different than Signed-off-by. These should
be the same, so can you fix the commit author to be the same as SoB?

> 
> Signed-off-by: Dongjin Yang <dj76.yang@...sung.com>

Fixes: 68277749a013 ("dt-bindings: dwmac: Add bindings for new Loongson
SoC and bridge chip")


> ---
>  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2d5248f..36c85eb 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -53,20 +53,18 @@ properties:
>          - allwinner,sun8i-r40-gmac
>          - allwinner,sun8i-v3s-emac
>          - allwinner,sun50i-a64-emac
> -        - loongson,ls2k-dwmac
> -        - loongson,ls7a-dwmac
>          - amlogic,meson6-dwmac
>          - amlogic,meson8b-dwmac
>          - amlogic,meson8m2-dwmac
>          - amlogic,meson-gxbb-dwmac
>          - amlogic,meson-axg-dwmac
> -        - loongson,ls2k-dwmac
> -        - loongson,ls7a-dwmac
>          - ingenic,jz4775-mac
>          - ingenic,x1000-mac
>          - ingenic,x1600-mac
>          - ingenic,x1830-mac
>          - ingenic,x2000-mac
> +        - loongson,ls2k-dwmac
> +        - loongson,ls7a-dwmac
>          - rockchip,px30-gmac
>          - rockchip,rk3128-gmac
>          - rockchip,rk3228-gmac


Best regards,
Krzysztof