lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Apr 2022 11:53:40 +0200 From: Patrik Jakobsson <patrik.r.jakobsson@...il.com> To: Xiaomeng Tong <xiam0nd.tong@...il.com> Cc: David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Zhao Yakui <yakui.zhao@...el.com>, Dave Airlie <airlied@...hat.com>, dri-devel <dri-devel@...ts.freedesktop.org>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 3/5] gma500: fix a missing break in psb_intel_crtc_mode_set On Wed, Mar 30, 2022 at 2:03 PM Xiaomeng Tong <xiam0nd.tong@...il.com> wrote: > > Instead of exiting the loop as expected when an entry is found, the > list_for_each_entry() continues until the traversal is complete. It > could result in multiple 'is_*' flags being set with true mistakely. > > To fix this, when found the entry, add a break after the switch > statement. > > Fixes: 89c78134cc54d (" gma500: Add Poulsbo support") > Signed-off-by: Xiaomeng Tong <xiam0nd.tong@...il.com> This patch doesn't apply for me and needs to be rebased on top of drm-misc-next or drm-tip. On Poulsbo there should only be one encoder per crtc so this is only a theoretical issue. But it is good practice to exit the loop early if we can so the patch still makes sense. Also, please use the correct subject prefix: drm/gma500: instead of just gma500:. Thanks Patrik > --- > drivers/gpu/drm/gma500/psb_intel_display.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c > index 42d1a733e124..85fc61bf333a 100644 > --- a/drivers/gpu/drm/gma500/psb_intel_display.c > +++ b/drivers/gpu/drm/gma500/psb_intel_display.c > @@ -134,6 +134,8 @@ static int psb_intel_crtc_mode_set(struct drm_crtc *crtc, > is_tv = true; > break; > } > + > + break; > } > > refclk = 96000; > -- > 2.17.1 >
Powered by blists - more mailing lists