linux-kernel - Re: [PATCH -next] KVM: x86/mmu: Fix return value check in kvm_mmu_init_tdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b262351-c56a-9c85-6038-d23a425b34f0@redhat.com>
Date:   Fri, 1 Apr 2022 13:23:11 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH -next] KVM: x86/mmu: Fix return value check in
 kvm_mmu_init_tdp_mmu()

On 4/1/22 09:15, Yang Yingliang wrote:
> If alloc_workqueue() fails, it returns NULL pointer, replaces
> IS_ERR() check with NULL pointer check.
> 
> Fixes: 1a3320dd2939 ("KVM: MMU: propagate alloc_workqueue failure")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>   arch/x86/kvm/mmu/tdp_mmu.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c
> index a2f9a34a0168..7bddbb51033a 100644
> --- a/arch/x86/kvm/mmu/tdp_mmu.c
> +++ b/arch/x86/kvm/mmu/tdp_mmu.c
> @@ -22,8 +22,8 @@ int kvm_mmu_init_tdp_mmu(struct kvm *kvm)
>   		return 0;
>   
>   	wq = alloc_workqueue("kvm", WQ_UNBOUND|WQ_MEM_RECLAIM|WQ_CPU_INTENSIVE, 0);
> -	if (IS_ERR(wq))
> -		return PTR_ERR(wq);
> +	if (!wq)
> +		return -ENOMEM;
>   
>   	/* This should not be changed for the lifetime of the VM. */
>   	kvm->arch.tdp_mmu_enabled = true;

Sent already by Dan Carpenter, thanks though!

Paolo