linux-kernel - RE: [PATCH 3/3] iio: sysfs-trigger: replace usage of found with dedicated list iterator variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Apr 2022 12:41:58 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Jakob Koschel <jakobkoschel@...il.com>,
        Jonathan Cameron <jic23@...nel.org>
CC:     Lars-Peter Clausen <lars@...afoo.de>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mike Rapoport <rppt@...nel.org>,
        Brian Johannesmeyer <bjohannesmeyer@...il.com>,
        Cristiano Giuffrida <c.giuffrida@...nl>,
        "Bos, H.J." <h.j.bos@...nl>
Subject: RE: [PATCH 3/3] iio: sysfs-trigger: replace usage of found with
 dedicated list iterator variable



> -----Original Message-----
> From: Jakob Koschel <jakobkoschel@...il.com>
> Sent: Friday, April 1, 2022 1:07 AM
> To: Jonathan Cameron <jic23@...nel.org>
> Cc: Lars-Peter Clausen <lars@...afoo.de>; Dan Carpenter
> <dan.carpenter@...cle.com>; Jakob Koschel
> <jakobkoschel@...il.com>; linux-iio@...r.kernel.org; linux-
> kernel@...r.kernel.org; Mike Rapoport <rppt@...nel.org>; Brian
> Johannesmeyer <bjohannesmeyer@...il.com>; Cristiano Giuffrida
> <c.giuffrida@...nl>; Bos, H.J. <h.j.bos@...nl>
> Subject: [PATCH 3/3] iio: sysfs-trigger: replace usage of found with
> dedicated list iterator variable
> 
> [External]
> 
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
> 
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
> 
> Link: https://urldefense.com/v3/__https://lore.kernel.org/all/CAHk-
> =wgRr_D8CB-D9Kg-
> c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@...l.gmail.com/__;!!A3Ni8CS0y
> 2Y!q8mEciLiCAWjMGEwW9jHDD2DoeaKzrMwtUcRCNAZ0gW9DPBVtJk
> xR5FMPPCJNw$  [1]
> Signed-off-by: Jakob Koschel <jakobkoschel@...il.com>
> ---

Reviewed-by: Nuno Sá <nuno.sa@...log.com>