linux-kernel - Re: [PATCH 0/7] TPS6598x PD tracing and other improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkcC5XKZzIQBID8w@kuha.fi.intel.com>
Date:   Fri, 1 Apr 2022 16:49:25 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>
Cc:     linux-usb@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sven Peter <sven@...npeter.dev>,
        Guido Günther <agx@...xcpu.org>,
        Angus Ainslie <angus@...ea.ca>,
        Hector Martin <marcan@...can.st>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        linux-kernel@...r.kernel.org, kernel@...i.sm
Subject: Re: [PATCH 0/7] TPS6598x PD tracing and other improvements

Hi,

On Thu, Mar 17, 2022 at 04:45:11PM +0100, Sebastian Krzyszkowiak wrote:
> This is a series developed for the Librem 5 phone, which uses TPS65982
> as its USB-C controller. Implemented are Power Delivery sink contract
> tracing and exporting negotiated power values as power supply properties,
> fixes for data role swapping, status register caching and a debugfs entry
> for querying customer use word of the firmware running on the controller.
> 
> Angus Ainslie (3):
>   usb: typec: tipd: set the data role on tps IRQ
>   usb: typec: tipd: Add trace event for SINK PD contract
>   usb: typec: tipd: Provide POWER_SUPPLY_PROP_{CURRENT,VOLTAGE}_MAX
> 
> Guido Günther (2):
>   usb: typec: tipd: Only update power status on IRQ
>   usb: typec: tipd: Add debugfs entries for customer use word
> 
> Sebastian Krzyszkowiak (2):
>   usb: typec: tipd: Provide POWER_SUPPLY_PROP_PRESENT
>   usb: typec: tipd: Fail probe when the controller is in BOOT mode
> 
>  drivers/usb/typec/tipd/core.c     | 263 ++++++++++++++++++++++++++----
>  drivers/usb/typec/tipd/tps6598x.h |  30 ++++
>  drivers/usb/typec/tipd/trace.h    |  38 +++++
>  3 files changed, 302 insertions(+), 29 deletions(-)

These look pretty good to me. I'll see if I can test these on Monday -
I finally have access to a machine again that actually has TI PD
controller. But I will give my comments then in any case, if there is
anything to comment.

But related to patch 3/7, there is a series in works that would expose
the PDOs in sysfs [1]. I was wondering have you guys noticed it, and
would that actually work also in your case?

[1] https://lore.kernel.org/linux-usb/20220203144657.16527-1-heikki.krogerus@linux.intel.com/

Br,

-- 
heikki