linux-kernel - Re: [PATCH v2 1/2] spi: dt-bindings: qcom,spi-geni-qcom: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220401135224.GA40286@9a2d8922b8f1>
Date:   Fri, 1 Apr 2022 19:22:24 +0530
From:   Kuldeep Singh <singh.kuldeep87k@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Mark Brown <broonie@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org
Subject: Re: [PATCH v2 1/2] spi: dt-bindings: qcom,spi-geni-qcom: convert to
 dtschema

On Thu, Mar 31, 2022 at 09:40:08PM +0200, Krzysztof Kozlowski wrote:
> On 31/03/2022 19:58, Kuldeep Singh wrote:
> > On Thu, Mar 31, 2022 at 06:02:47PM +0200, Krzysztof Kozlowski wrote:
> >> Convert the GENI based Qualcomm Universal Peripheral (QUP) Serial
> >> Peripheral Interface (SPI) bindings to DT Schema.
> >>
> >> The original bindings in TXT were not complete, so add during conversion
> >> properties already used in DTS and/or in the driver: reg-names, dmas,
> >> interconnects, operating points and power-domains.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

[...]

> >> +  reg:
> >> +    maxItems: 1
> >> +
> >> +  reg-names:
> >> +    const: se
> > 
> > Why reg-names is required?
> > Reg contain max 1 value, we can skip reg-names like other users.
> > 
> > Also, "se" is used as clock name and using it again for reg-names?
> > I think this is wrong and reg-names shouldn't be documented.
> 
> reg-names are not required. If you ask why they are documented? As I
> wrote in commit msg - bindings were not fully updated to DTSes being used.

Hi Krzysztof,

Power-domains, operating-points etc. makes sense, but reg-names?

With quick search, sm8150.dtsi is the only user of reg-names. Moreover,
there is no reference in driver to incorporate it.
Driver(drivers/spi/spi-geni-qcom.c) looks for "se" as clock name and not
as reg-name. If there's one, kindly help in pointing out.

It seems you are adding reg-names because some DT is using it and no
other reason. And with no reference even in driver, that's surely not a
way to go ahead as you have been advising the same in past.

-Kuldeep